Uh oh!
There was an error while loading. Please reload this page.
Don't call openBrowser for smoke test - #1460
Closed
tuchk4 wants to merge 1 commit into
Closed
Conversation
tuchk4
commented
Jan 30, 2017
ContributorAuthor
@EnoahNetzach check this also please. This relate to new e2e tests |
Contributor
Hesitant on this one. I'd leave it in. This increases our coverage for cases like |
Timer
commented
Feb 15, 2017
Contributor
Could you (in theory) execute |
gaearon
commented
Feb 15, 2017
Contributor
Yea. That's the workaround I'd suggest for local testing if it's too annoying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nut sure but seems openBrowser should not be called for smoke test