Uh oh!
There was an error while loading. Please reload this page.
Warn about duplicate dependencies - #1866
Conversation
facebook-github-bot
commented
Mar 20, 2017
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
facebook-github-bot
commented
Mar 20, 2017
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Does anyone have an idea why build is failing on AppVeyor? It says |
Timer
commented
Mar 22, 2017
@gaearon should we put this in a 0.9 release or 0.10? |
564eee5 to
3c1211fCompareTimer
commented
Apr 19, 2017
I'm going to punt this to 0.10 for now since some people rely on CI to check warnings and consider them build failures. I don't want to accidentally upset anyone. Sorry for the wait, @darrenscerri! |
darrenscerri
commented
Apr 20, 2017
Ok, makes sense. |
@darrenscerri could you please close this PR and open a new one from a feature branch that's on master? |
darrenscerri
commented
Apr 21, 2017
Timer
commented
Apr 21, 2017
Thanks so much, @darrenscerri! |
Add duplicate-package-checker-webpack-plugin as proposed here: #1844 .
Display compilation warnings on build.
This feature can be quickly tested by creating an app, installing an old version of
fbjs(yarn add fbjs@0.6.0) and importingfbjsfromApp.js. This will result in having duplicatefbjspackages since React already requires the most recent version offbjs.