Uh oh!
There was an error while loading. Please reload this page.
Update the string that clears the console. - #2071
Conversation
react#1914 I've tested it with Windows 10 and 7, node versions from ~5.0.0 up to 7.7.0. Didn't managed to test it on 8 but it should be fine.
facebook-github-bot
commented
May 3, 2017
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
gaearon
commented
May 4, 2017
I'm pretty sure |
DanielBadan
commented
May 8, 2017
It's probably not relevant any more. It worked for me without |
In the beginning we only used Eventually we ended up copying Jest via jestjs/jest#2230. Jest's latest sequence is https://github.com/facebook/jest/blob/master/packages/jest-cli/src/constants.js#L15, which appears identical to what we're still doing. We can try |
Add windows specific string for clearing the console.
DanielBadan
commented
May 12, 2017
It seems to work with In windows 10 it clears the console with Git Bash, CMD and Powershell. |
gaearon
commented
May 17, 2017
Am I correct that the current string fails in GitBash but works in other environments? |
DanielBadan
commented
May 18, 2017
Yes. |
gaearon
commented
May 18, 2017
I’ll test this later today. |
gaearon
commented
May 18, 2017
We’ll need a matching PR to Jest. |
This does seem to work better on a new Windows laptop I'm using. I don't understand why though. It even works in PowerShell but old sequence doesn't (with PowerShell too) on my new Windows laptop. How is this possible? Could some new Windows 10 versions break the old sequence? |
DanielBadan
commented
Jun 30, 2017
Probably just another weird thing of windows, the original sequence stopped working for me after an update. |
gaearon
commented
Jan 8, 2018
Can you send this PR to Jest too? http://github.com/facebook/jest |
gaearon
commented
Jan 8, 2018
Never mind, I sent jestjs/jest#5251. |
gaearon
commented
Jan 15, 2018
This is out in |
* Update the string that clears the console. react#1914 I've tested it with Windows 10 and 7, node versions from ~5.0.0 up to 7.7.0. Didn't managed to test it on 8 but it should be fine. * Update windows string Add windows specific string for clearing the console.
#1914
I've tested it with Windows 10 and 7, node versions from ~5.0.0 up to 7.7.0.
Didn't managed to test it on 8 but it should work to.
Before

After
