Uh oh!
There was an error while loading. Please reload this page.
Add custom eslint formatter - #2136
Closed
sidoshi wants to merge 1 commit into
Closed
Conversation
gaearon
commented
May 12, 2017
Contributor
Any reason you closed? |
sidoshi
commented
May 12, 2017
ContributorAuthor
While reformatting my code after testing I used absolute require in |
gaearon
commented
May 12, 2017
Contributor
We probably don't want this formatter to live in |
sidoshi
commented
May 12, 2017
ContributorAuthor
Sure. |
sidoshi
commented
May 12, 2017
ContributorAuthor
I have pushed to the branch I have sent pull request from. But the changes doesn't seem to be updated. Is it because I have closed the PR? |
gaearon
commented
May 12, 2017
Contributor
Yea, could you push to a new branch and open another PR please? |
sidoshi
commented
May 12, 2017
ContributorAuthor
Okay doing it. Thanks. |
sidoshi
commented
May 12, 2017
ContributorAuthor
See #2138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces hacky code to format eslint errors by using custom loader.
I built this formatter on top of the default
stylishformatter.It omits warnings if there are any eslint errors as required in #2120 and errors and warnings looks the same as earlier.
Closes#2121