Skip to content

Add custom eslint formatter - #2136

Closed
sidoshi wants to merge 1 commit into
react:masterfrom
sidoshi:eslint-formatter
Closed

Add custom eslint formatter#2136
sidoshi wants to merge 1 commit into
react:masterfrom
sidoshi:eslint-formatter

Conversation

@sidoshi

Copy link
Copy Markdown
Contributor

Replaces hacky code to format eslint errors by using custom loader.

I built this formatter on top of the default stylish formatter.
It omits warnings if there are any eslint errors as required in #2120 and errors and warnings looks the same as earlier.

Closes#2121

@gaearon

Copy link
Copy Markdown
Contributor

Any reason you closed?

@sidoshi

Copy link
Copy Markdown
ContributorAuthor

While reformatting my code after testing I used absolute require in require ('formatter') instead of relative, like require('./formatter'). Trying to fix it without opening another pull request.

@gaearon

Copy link
Copy Markdown
Contributor

We probably don't want this formatter to live in react-scripts because we don't want to keep it in user code after ejecting. Let's move it to react-dev-utils?

@sidoshi

Copy link
Copy Markdown
ContributorAuthor

Sure.

@sidoshi

Copy link
Copy Markdown
ContributorAuthor

I have pushed to the branch I have sent pull request from. But the changes doesn't seem to be updated. Is it because I have closed the PR?
Sorry for the inconvenience, I am learning how this things work.

@gaearon

Copy link
Copy Markdown
Contributor

Yea, could you push to a new branch and open another PR please?

@sidoshi

Copy link
Copy Markdown
ContributorAuthor

Okay doing it. Thanks.

@sidoshi

Copy link
Copy Markdown
ContributorAuthor

See #2138

@locklockBot locked and limited conversation to collaborators Jan 21, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sidoshi@gaearon@facebook-github-bot