Uh oh!
There was an error while loading. Please reload this page.
Turn off .babelrc usage (fixes #233) - #236
Merged
Merged
Conversation
mxstbr
commented
Jul 27, 2016
Contributor
Awesome, thanks so much @alexzherdev! |
mxstbr
commented
Jul 27, 2016
Contributor
Awesome, thanks so much @alexzherdev! 🎉 |
gaearon
commented
Jul 27, 2016
Contributor
Let’s wait for e2e next time for things that touch configs 😉 |
alexzherdev
commented
Jul 27, 2016
ContributorAuthor
@gaearon do you mean the end-to-end flow mentioned in CONTRIBUTING.md? |
gaearon
commented
Jul 27, 2016
Contributor
@alexzherdev No, I meant waiting for Travis test before merging, this was a comment to @mxstbr. Sometimes Travis catches stuff that manual end to end flow might not catch. |
mxstbr
commented
Jul 27, 2016
Contributor
@gaearon I swear Travis was green, I actually looked at the log and waited for it to finish… |
gaearon
commented
Jul 27, 2016
Contributor
Haha, okay then, sorry! Maybe it restarts when I merge something else to master? Don't worry then. |
mxstbr
commented
Jul 27, 2016
Contributor
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Here is how I verified.
With the fix in place, I'm no longer getting the "Failed to compile" message.