Skip to content

Turn off .babelrc usage (fixes #233) - #236

Merged
mxstbr merged 1 commit into
react:masterfrom
alexzherdev:babelrc
Jul 27, 2016
Merged

Turn off .babelrc usage (fixes #233)#236
mxstbr merged 1 commit into
react:masterfrom
alexzherdev:babelrc

Conversation

@alexzherdev

Copy link
Copy Markdown
Contributor

Here is how I verified.

  1. cloned create-react-app
  2. created .babelrc in the parent directory as specified in "npm start" error if there is a .babelrc file in parent folder #233
  3. ran npm start in create-react-app and got the error message

With the fix in place, I'm no longer getting the "Failed to compile" message.

@ghostghost added the CLA Signed label Jul 27, 2016
@mxstbr

Copy link
Copy Markdown
Contributor

Awesome, thanks so much @alexzherdev!

@mxstbr

Copy link
Copy Markdown
Contributor

Awesome, thanks so much @alexzherdev! 🎉

@gaearon

Copy link
Copy Markdown
Contributor

Let’s wait for e2e next time for things that touch configs 😉

@alexzherdev

Copy link
Copy Markdown
ContributorAuthor

@gaearon do you mean the end-to-end flow mentioned in CONTRIBUTING.md?
I just did it and created a project with npm run create-react-app. It worked fine but thanks for making me aware of this.

@gaearon

Copy link
Copy Markdown
Contributor

@alexzherdev No, I meant waiting for Travis test before merging, this was a comment to @mxstbr. Sometimes Travis catches stuff that manual end to end flow might not catch.

@mxstbr

Copy link
Copy Markdown
Contributor

@gaearon I swear Travis was green, I actually looked at the log and waited for it to finish…

@gaearon

Copy link
Copy Markdown
Contributor

Haha, okay then, sorry! Maybe it restarts when I merge something else to master? Don't worry then.

@mxstbr

Copy link
Copy Markdown
Contributor

screen shot 2016-07-27 at 17 02 08

@gaearongaearon added this to the 0.2.0 milestone Jul 27, 2016
@gaearongaearon mentioned this pull request Jul 27, 2016
@locklockBot locked and limited conversation to collaborators Jan 22, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexzherdev@mxstbr@gaearon