Skip to content

E2E testing enhancements - #2408

Merged
gaearon merged 7 commits into
react:masterfrom
EnoahNetzach:local-testing
Jun 26, 2017
Merged

E2E testing enhancements#2408
gaearon merged 7 commits into
react:masterfrom
EnoahNetzach:local-testing

Conversation

@EnoahNetzach

@EnoahNetzachEnoahNetzach commented May 29, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Features to add:

  • local testing with docker

  • bash callback after the docker entrypoint

  • docs explaining how testing is managed and how to contribute

  • test modified files

@EnoahNetzachEnoahNetzach mentioned this pull request May 29, 2017
Merged
6 tasks
@ro-savage

ro-savage commented May 29, 2017

Copy link
Copy Markdown
Contributor

Is it possible to pass jest errors along to the e2e tests?

I'm not entirely sure what you mean.
jest runs should always log to terminal, isn't it?

I tried to reproduce this and wasn't able to. So just ignore that comment, if I come across it again / can reproduce I'll let you know.

@ro-savage

ro-savage commented May 29, 2017

Copy link
Copy Markdown
Contributor

Actually, can confirm that the errors are being passed correctly. The error I saw was only because I had edited the tmp files directly.

Happy to review your readme etc when its ready. Just ping me.

Thanks again for your help debugging the e2e stuff.

ro-savage
ro-savage reviewed Jun 1, 2017
View reviewed changes

@ro-savagero-savage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

Just some minor thoughts/tweaks.

Still wonder if its possible to direct people to where the test failed test, development, production or eject when it does fail. Just since people often skip readme's. Although it might have just been a rare edge case (or stupidity) where it wasn't obvious that test was failing rather than development / production.

Comment threadpackages/react-scripts/fixtures/kitchensink/README.md Outdated
This is a simple script that runs a **Docker** container, where the node version, git branch to clone, test suite, and whether to run it with `yarn` or `npm` can be chosen.
Simply run `yarn e2e:docker -- --help` to get additional info.

N.B.: this command will clone the local repository in the docker container, so any uncommitted changes are ignored.

@ro-savagero-savageJun 1, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to run this on uncommitted changes. As normally I'd make changes, write tests, run tests. And then if everything works commit changes.

With this, I'd be making changes, committing, testing, making changes, committing, testing, etc.

@EnoahNetzachEnoahNetzachJun 1, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, coming soon!

Comment threadCONTRIBUTING.md
## Contributing to E2E (end to end) tests

All information are in the dedicated [README](/packages/react-scripts/fixtures/kitchensink/README.md).

@ro-savagero-savageJun 1, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth putting in a TL:DR?

TL:DR use the command yarn e2e:docker to run unit and e2e tests

@gaearon
gaearon merged commit 1f91848 into react:masterJun 26, 2017
@gaearon

gaearon commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

Thanks for this!

@gaearongaearon added this to the 1.0.8 milestone Jun 26, 2017
@EnoahNetzach
EnoahNetzach deleted the local-testing branch June 26, 2017 17:01
@gaearon

gaearon commented Jun 28, 2017

Copy link
Copy Markdown
Contributor

Can you add info on how to setup Docker for this? At least a link. I can't seem to figure it out.

@EnoahNetzach

EnoahNetzach commented Jun 28, 2017

Copy link
Copy Markdown
ContributorAuthor

Do you mean how to setup Docker itself on various OSes?

@gaearon

gaearon commented Jun 28, 2017

Copy link
Copy Markdown
Contributor

I guess I'll try official instructions (linking to them would be welcome).
I hoped brew install docker would work but I can't get daemon to run.

@EnoahNetzach

EnoahNetzach commented Jun 28, 2017

Copy link
Copy Markdown
ContributorAuthor

https://docs.docker.com/engine/installation/, I'll link them in the docs in a minute

@EnoahNetzach

EnoahNetzach commented Jun 28, 2017

Copy link
Copy Markdown
ContributorAuthor

https://docs.docker.com/docker-for-mac/install/ specifically for Mac

@EnoahNetzachEnoahNetzach mentioned this pull request Jun 28, 2017
Merged
@gaearongaearon mentioned this pull request Jun 28, 2017
Merged
@Timer

Timer commented Jun 28, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

FWIW brew cask install docker is what works. Make sure you open the docker application, as it populates the CLI tool into your PATH.

romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
@EnoahNetzach@romaindso
E2E testing enhancements (react#2408)
9b0e991
* Local testing with docker
* Docs on e2e testing
* `bash` callback after docker
* Add a TL;DR in the CONTRIBUTING section
* Local e2e testing with modified files
* Remove the N.B. from the README
* Fixed a fixme in e2e doc
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
@EnoahNetzach@wmonk
E2E testing enhancements (#2408)
4a6c5b4
* Local testing with docker
* Docs on e2e testing
* `bash` callback after docker
* Add a TL;DR in the CONTRIBUTING section
* Local e2e testing with modified files
* Remove the N.B. from the README
* Fixed a fixme in e2e doc
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
@EnoahNetzach@morgs32
E2E testing enhancements (react#2408)
3237b38
* Local testing with docker
* Docs on e2e testing
* `bash` callback after docker
* Add a TL;DR in the CONTRIBUTING section
* Local e2e testing with modified files
* Remove the N.B. from the README
* Fixed a fixme in e2e doc
@locklockBot locked and limited conversation to collaborators Jan 21, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ro-savagero-savagero-savage left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: internal

Projects

None yet

Milestone

1.0.8

Development

Successfully merging this pull request may close these issues.

5 participants

@EnoahNetzach@ro-savage@gaearon@Timer@facebook-github-bot