Uh oh!
There was an error while loading. Please reload this page.
Conversation
gaearon
commented
Jul 27, 2016
ContributorAuthor
(I will probably squash first several commits though) |
chocnut
commented
Jul 27, 2016
Contributor
gaearon
commented
Jul 27, 2016
ContributorAuthor
@chocnut Thanks, this is really good for now! I think it was failing because of regex replacement of any numbers in entry points—which happened to replace parts of test directory paths on CI 😄 . I’m currently looking into another approach to this. I made webpack configs parameterizable, but to be honest, I want to find a way to get rid of port/host in configs completely if possible. |
ContributorAuthor
There was a problem hiding this comment.
Haha seriously. This also fixes #194 in my testing.
I think this was only necessary because contentBase is configurable in Webpack.. which it isn’t here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m taking #101 and adding some minor refactoring on top.
I will merge without squashing so original author commits are preserved.