Skip to content

Fixing eject script on windows + yarn / AppVeyor - #2633

Closed
ro-savage wants to merge 1 commit into
react:masterfrom
ro-savage:appveyor-fix
Closed

Fixing eject script on windows + yarn / AppVeyor#2633
ro-savage wants to merge 1 commit into
react:masterfrom
ro-savage:appveyor-fix

Conversation

@ro-savage

Copy link
Copy Markdown
Contributor

Just testing for now. Let's see what happens with AppVayor

@gaearon

Copy link
Copy Markdown
Contributor

It would be great if you could take out the expensive unrelated parts, like I did in #2628. I don't have a lot of time to dig into this, so I need fast iteration speed. It's essential that we don't block each other for more than five minutes.

@ro-savage

ro-savage commented Jun 27, 2017

Copy link
Copy Markdown
ContributorAuthor

This just passed the simple test suite. So I believe this fixes the issue.

Basically windows can't find yarnpkg, so we specially have to call yarnpkg.cmd... why... I dunno... I haven't used windows for a long time but it works.

See yarnpkg/yarn#2591 if you'd like to try and decipher it. Not much there though.

@gaearon

Copy link
Copy Markdown
Contributor

Hmm. I don't think this worked:

Running yarn...
'"C:\Users\appveyor\AppData\Local\Temp\1\tmp.TFH3Fmthu8\test-app\\yarn.cmd"' is not recognized as an internal or external command,
operable program or batch file.
Ejected successfully!
Please consider sharing why you ejected in this survey:

It passed CI but isn't working.

@ro-savage

ro-savage commented Jun 27, 2017

Copy link
Copy Markdown
ContributorAuthor

Yep. You're right.

Can't be of much help then. Good luck @gaearon

@gaearon

Copy link
Copy Markdown
Contributor

Haha thanks 😛
If you have more ideas let me know.

@gaearongaearon mentioned this pull request Jun 27, 2017
@locklockBot locked and limited conversation to collaborators Jan 21, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ro-savage@gaearon@facebook-github-bot