Uh oh!
There was an error while loading. Please reload this page.
Added env (IGNORE_OPEN) before openBrowser. - #306
Conversation
… browser in case of developement with Electron.
ghost
commented
Jul 31, 2016
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
ghost
commented
Aug 1, 2016
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
gaearon
commented
Aug 1, 2016
Hey! Thanks for the PR. I think we won’t take it. I understand this is minimal, but we specifically don’t plan to tailor this tool for Electron apps. It would be frustrating if we merged this now, only to break something else later on. I would encourage you to fork |
aeneasr
commented
Sep 23, 2016
Unfortunately this causes my docker-compose setup to fail: |
This env is chosen to make sure that there isn't a browser window showing up, when developing a Electron application. The start.js script can be used in the Electron index.js for launching the dev server and loading its url.