update jest to 22 and support watchPathIgnorePatterns configuration by aisensiy · Pull Request #3124 · react/create-react-app

aisensiy · 2017-09-14T06:06:00Z

The jest just add a new configuration property watchPathIgnorePatterns in version 21.0.0+ which will ignore some path patterns in watch mode.

This configuration property make jest support tests which will generate a new file after running the test. Without this watch ignore property, any test which will generate a new file during test in watch mode will make a infinite loop for test. For example if I use pact-js in my create-react-app project. The pact-js test will generate a new pact file after running the pact contract test. I create a repository pact-integration-with-react-app to demonstrate this case. Run all the test in watch mode will show the infinite loop.

This is the document for the new watchPathIgnorePatterns in jest.

react-scripts-dangerous · 2017-09-14T12:54:42Z

Hello! I'm a bot that helps facilitate testing pull requests.

Your pull request (commit 9b78efc3d74b86b1a5d9eb5a68daec1bf9304331) has been released on npm for testing purposes.

npm i react-scripts-dangerous@1.0.14-9b78efc.0
# or
yarn add react-scripts-dangerous@1.0.14-9b78efc.0
# or
create-react-app --scripts-version=react-scripts-dangerous@1.0.14-9b78efc.0 folder/

Thanks for your contribution!

gaearon · 2017-09-14T16:33:37Z

That bot by @Timer is amazing 😮
^^ @vjeux @cpojer check this out

vjeux · 2017-09-14T16:39:57Z

I've always wanted to build one like it! So good it's actually working :)

cpojer · 2017-09-15T01:06:10Z

woah, shit. This is cool.

aisensiy · 2017-09-15T02:22:02Z

Amazing 😮

oskarkook · 2017-09-15T20:28:21Z

So 21.1.0 was released. Might as well update to that? Related issue: #2639.

aisensiy · 2017-09-17T06:35:07Z

You mean upgrade to 21.1.0?

react-scripts-dangerous · 2017-09-18T14:02:33Z

Hello! I'm a bot that helps facilitate testing pull requests.

Your pull request (commit 95040cb37b04b28e1ea4cb73542381f162f0b09c) has been released on npm for testing purposes.

npm i react-scripts-dangerous@1.0.14-95040cb.0
# or
yarn add react-scripts-dangerous@1.0.14-95040cb.0
# or
create-react-app --scripts-version=react-scripts-dangerous@1.0.14-95040cb.0 folder/

Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk!

Thanks for your contribution!

aisensiy · 2017-09-20T02:09:43Z

Anybody review this PR?

aisensiy · 2017-09-27T03:03:50Z

Anybody review this PR? @gaearon @vjeux @cpojer

Timer · 2017-09-27T03:32:45Z

@aisensiy bumping major versions of Jest can only be done in a major release of react-scripts, so this is on the back burner until v2; sorry!

aisensiy · 2017-09-27T03:34:57Z

@Timer Got it. Thanks for your reply.

FezVrasta · 2017-12-19T18:09:19Z

It doesn't seem like major versions of Jest introduced any breaking change so far, why are you still holding on this?

102 · 2017-12-20T06:56:32Z

@FezVrasta looks like v22 adds a lot of breaking changes: CHANGELOG.md

aisensiy · 2017-12-25T14:20:47Z

Anything I can help?

SimenB · 2018-01-08T15:30:46Z

Any news here? We're getting quite a lot issues in the Jest repo with people trying to upgrade jest themselves and getting relatively obscure errors (it probably silently "worked" with 21 to upgrade, which is why 22 is generating issues as it explodes).

Happy to help if needed 🙂 (This PR should probably jump straight to 22 and skip 21)

gaearon · 2018-01-08T22:44:19Z

If you can get it to 22 and pass CI that would be great!

It would also be nice to know why updating jest manually breaks it. (I'd expect there to just be no effect since it should not be required—see #1795)

gaearon · 2018-01-08T22:48:09Z

This looks scary though jestjs/jest#5169

SimenB · 2018-01-08T22:54:46Z

If you can get it to 22 and pass CI that would be great!

I'll give it a whack tomorrow.

It would also be nice to know why updating jest manually breaks it. (I'd expect there to just be no effect since it should not be required—see #1795)

Shooting in the dark, but my guess is either a hoisting bug in yarn/npm or some weird (potentially circular) dependency tree we've gotten ourselves into.

This looks scary though jestjs/jest#5169

Will be solved by jestjs/jest#5252 (so we might want to push out a release of at least that module first)

This reverts commit 62aec9a.

…eact#3124) * update jest to 21.0.2 to support watchPathIgnorePatterns configuration * update jest to 21.1.0 * Try bumping Jest * Bump babel-jest * Try to debug weird CI failure * Remove debug code * Bump other Jest packages * ffs * temp * Revert "temp" This reverts commit 62aec9a.

SimenB · 2018-01-11T10:01:39Z

@Timer You probably want 22.0.6 (released 15 minutes ago), as a memory leak was just fixed (jestjs/jest#5279).

(Also, 🎉)

…eact#3124) * update jest to 21.0.2 to support watchPathIgnorePatterns configuration * update jest to 21.1.0 * Try bumping Jest * Bump babel-jest * Try to debug weird CI failure * Remove debug code * Bump other Jest packages * ffs * temp * Revert "temp" This reverts commit 62aec9a.

…3124) * update jest to 21.0.2 to support watchPathIgnorePatterns configuration * update jest to 21.1.0 * Try bumping Jest * Bump babel-jest * Try to debug weird CI failure * Remove debug code * Bump other Jest packages * ffs * temp * Revert "temp" This reverts commit 62aec9a.

…eact#3124) * update jest to 21.0.2 to support watchPathIgnorePatterns configuration * update jest to 21.1.0 * Try bumping Jest * Bump babel-jest * Try to debug weird CI failure * Remove debug code * Bump other Jest packages * ffs * temp * Revert "temp" This reverts commit 62aec9a.

mzedeler · 2018-06-27T12:38:46Z

I can see that this was merged to the next branch. How much work is left before it can be released?

(As a sidenote, I noted that the react-dev-tools version in package.json should be updated, because what is on master is higher than what is on next.)

bugzpodder · 2018-06-27T15:39:52Z

@mzedeler please follow instructions at #3815 to find out how to upgrade to the alphha version of create-react-app@2.0, which contains jest 22.

…eact#3124) * update jest to 21.0.2 to support watchPathIgnorePatterns configuration * update jest to 21.1.0 * Try bumping Jest * Bump babel-jest * Try to debug weird CI failure * Remove debug code * Bump other Jest packages * ffs * temp * Revert "temp" This reverts commit 62aec9a.

gaearon · 2018-10-02T01:51:18Z

It shipped in 2.0.
https://reactjs.org/blog/2018/10/01/create-react-app-v2.html

facebook-github-bot added the CLA Signed label Sep 14, 2017

Timer added this to the 2.0.0 milestone Sep 27, 2017

sorrycc mentioned this pull request Oct 1, 2017
早报汇总 @ 2017.9 sorrycc/blog#50
Open

Timer mentioned this pull request Oct 11, 2017
update jest to the latest version #3266
Closed

kwonoj mentioned this pull request Oct 27, 2017
Autopublish nightly package ReactiveX/rxjs#3008
Closed

Timer mentioned this pull request Nov 27, 2017
Jest 22 #2639
Closed

sorrycc mentioned this pull request Nov 30, 2017
早报汇总 @ 2017.9 sorrycc/zaobao#1
Open

gaearon changed the title ~~update jest to 21.0.2 to support watchPathIgnorePatterns configuration~~update jest to 22 to support watchPathIgnorePatterns configurationJan 9, 2018

gaearon changed the title ~~update jest to 22 to support watchPathIgnorePatterns configuration~~update jest to 22 and support watchPathIgnorePatterns configurationJan 10, 2018

gaearon changed the base branch from master to nextJanuary 10, 2018 15:17

gaearon force-pushed the next branch from abaf31a to 78d344cCompare January 10, 2018 15:18

gaearon added 4 commits January 11, 2018 01:40

Bump babel-jest
980e1a0

Try to debug weird CI failure
3cecb9d

Remove debug code
9fc9ac6

Bump other Jest packages
53f464c

Timer force-pushed the master branch from 584ade1 to 53f464cCompare January 11, 2018 06:40

Timer added the tag: enhancement label Jan 11, 2018

Timer added 3 commits January 11, 2018 02:11

ffs
8055d69

temp
62aec9a

Revert "temp"
024ce87
This reverts commit 62aec9a.

Timer merged this pull request into react:nextJan 11, 2018

gaearon mentioned this pull request Jan 14, 2018
react-scripts test is watching files in node_modules #2393
Closed

gaearon mentioned this pull request Jan 16, 2018
Roadmap for react-scripts@2.0 #3815
Closed

lockBot locked and limited conversation to collaborators Jan 19, 2019

Uh oh!

Uh oh!

Conversation

aisensiy commented Sep 14, 2017

Uh oh!

react-scripts-dangerous commented Sep 14, 2017

Uh oh!

gaearon commented Sep 14, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vjeux commented Sep 14, 2017

Uh oh!

cpojer commented Sep 15, 2017

Uh oh!

aisensiy commented Sep 15, 2017

Uh oh!

oskarkook commented Sep 15, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aisensiy commented Sep 17, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

react-scripts-dangerous commented Sep 18, 2017

Uh oh!

aisensiy commented Sep 20, 2017

Uh oh!

aisensiy commented Sep 27, 2017

Uh oh!

Timer commented Sep 27, 2017

Uh oh!

aisensiy commented Sep 27, 2017

Uh oh!

FezVrasta commented Dec 19, 2017

Uh oh!

102 commented Dec 20, 2017

Uh oh!

aisensiy commented Dec 25, 2017

Uh oh!

SimenB commented Jan 8, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaearon commented Jan 8, 2018

Uh oh!

gaearon commented Jan 8, 2018

Uh oh!

SimenB commented Jan 8, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SimenB commented Jan 11, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mzedeler commented Jun 27, 2018

Uh oh!

bugzpodder commented Jun 27, 2018

Uh oh!

gaearon commented Oct 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

gaearon commented Sep 14, 2017•
edited
Loading

oskarkook commented Sep 15, 2017•
edited
Loading

aisensiy commented Sep 17, 2017•
edited
Loading

SimenB commented Jan 8, 2018•
edited
Loading

SimenB commented Jan 8, 2018•
edited
Loading

SimenB commented Jan 11, 2018•
edited
Loading