Uh oh!
There was an error while loading. Please reload this page.
Install React Bootstrap Dependency - section added - #313
Conversation
ghost
commented
Aug 1, 2016
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
ghost
commented
Aug 1, 2016
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
gaearon
commented
Aug 1, 2016
This makes it sound a little like we officially recommend or require it. Can you remove "dependency" from the title and add a short intro explaining that it is not required for React but it is fairly popular so we provided some instructions? |
manavsehgal
commented
Aug 1, 2016
@gaearon makes sense. Done the intro and clarification as suggested. |
gaearon
commented
Aug 1, 2016
This looks very good, let’s just move this after |
manavsehgal
commented
Aug 1, 2016
Done. |
gaearon
commented
Aug 1, 2016
Thanks. If you'd like, I'd appreciate another PR that adds a table of contents to that README (since it's getting quite long). |
manavsehgal
commented
Aug 1, 2016
Will give it a go... |
No description provided.