Allow the dev server to watch for changes in src/node_modules by xjlim · Pull Request #3230 · react/create-react-app

xjlim · 2017-10-02T20:15:41Z

Building off #2760, this will allow dev server to watch for changes in the src/node_modules directory.

facebook-github-bot · 2017-10-02T20:15:46Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2017-10-02T20:28:44Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

react-scripts-dangerous · 2017-10-02T21:42:05Z

Hello! I'm a bot that helps facilitate testing pull requests.

Your pull request (commit b0ef885) has been released on npm for testing purposes.

npm i react-scripts-dangerous@1.0.15-b0ef885.0
# or
yarn add react-scripts-dangerous@1.0.15-b0ef885.0
# or
create-react-app --scripts-version=react-scripts-dangerous@1.0.15-b0ef885.0 folder/

Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk!

Thanks for your contribution!

Timer · 2017-10-02T23:51:17Z

I do not believe this regex works.

See said error:

xjlim · 2017-10-03T02:09:41Z

@Timer my bad, i have corrected it

Timer · 2017-10-03T02:37:47Z

paths.appSrc actually never has the trailing slash, but I dunno if we'll guarantee this in the future.

To ensure the trailing slash (and fixing the src2 problem), let's do path.normalize(paths.appSrc + '/').

Timer · 2017-10-03T02:56:10Z

Excellent, thanks much!

Timer · 2017-10-03T03:36:47Z

Oops, we broke AppVeyor; oh Windows. 🙄

#3232

mariuskava · 2017-10-03T15:36:29Z

watchOptions didn't change on 0.9.5 -> 1.0.0. So what exactly did cause the change in watcher behaviour?
If the behaviour changed because of some dependency update, then maybe we can fix that dependency?

Timer · 2017-10-03T16:58:02Z

@mariuskava this has never worked 😄

mariuskava · 2017-10-03T18:30:14Z

hmm. it is interesting :D do you mean it did never work or did it work in a way that it shouldn't?
I used src/**/node_modules from the beginning (I think it was a bit lower than 0.8.4) and it worked. Last week I updated 0.8.4 -> 1.0.14 and I noticed that the watcher doesn't watch any more :(. Then I found out the lastest working version was 0.9.5.

To reproduce a working version you can (checked a minute ago):

create-react-app test
cd test
npm install react-scripts@0.9.5
mkdir src/node_modules
echo "console.log('Test.js imported');" > src/node_modules/Test.js
mv src/index.js src/index.js.old
echo "import 'Test.js';" > src/index.js
cat src/index.js.old >> src/index.js
rm src/index.js.old
npm start

and then modify Test.js :)

Timer · 2017-10-03T19:26:45Z

It should never of worked, this goes back to v0.2.1; see #294.

If it did work, it was because of a bug in WebpackDevServer. Since WebpackDevServer fixed their bug (speculation based on your comment), this stopped working.

This regex change will allow src/**/node_modules to be watched again.

…react-app * 'master' of https://github.com/facebookincubator/create-react-app: Make error overlay to run in the context of the iframe (react#3142) Fix Windows compatibility (react#3232) Fix package management link in README (react#3227) Watch for changes in `src/**/node_modules` (react#3230) More spec compliant HTML template (react#2914) Minor change to highlight dev proxy behaviour (react#3075) Correct manual proxy documentation (react#3185) Improve grammar in README (react#3211) Publish Fix license comments Changelog for 1.0.14 BSD+Patents -> MIT (react#3189) Add link to active CSS modules discussion (react#3163) Update webpack-dev-server to 2.8.2 (react#3157) Part of class fields to stage 3 (react#2908) Update unclear wording in webpack config docs (react#3160) Display pid in already running message (react#3131) Link local react-error-overlay package in kitchensink test

gaearon · 2017-10-30T21:47:07Z

 watchOptions: {
- ignored: /node_modules/,
+ ignored: new RegExp(
+ `^(?!${path.normalize(paths.appSrc + '/')}).+[\\/]node_modules[\\/]`,


Note that technically this stays in ejected projects forever. It looks extremely cryptic.
Can we extract this somewhere to react-dev-utils?

…pescript * 'master' of https://github.com/wmonk/create-react-app-typescript: (265 commits) fix typo in changelog Update README For 2.13.0 v2.13.0 Remove tslint-loader from prod build (again) Include TypeScript as devDependency in boilerplate output Documented how to define custom module formats for the TypeScript compiler so that you can import images and other files (references wmonk#172) v2.12.0 Update README For 2.12.0 Update typescript to 2.6.2 v2.11.0 Update changelog for 2.11.0 Fixed problem with tsconfig.json baseUrl and paths Update createJestConfig.js Update changelog for 2.10.0 v2.10.0 Readd transformIgnorePatterns Update react-dev-utils Update package.json dependencies Readd Missing raf Package Update JestConfig Creation Fix Fix Missing Variable Fix package.json Merge pull request wmonk#204 from StefanSchoof/patch-1 Merge pull request wmonk#201 from StefanSchoof/patch-1 Merge pull request wmonk#199 from DorianGrey/master Merge pull request wmonk#165 from johnnyreilly/master Publish Add 1.0.17 changelog (#3402) Use new WebpackDevServer option (#3401) Fix grammar in README (#3394) Add link to VS Code troubleshooting guide (#3399) Update VS Code debug configuration (#3400) Update README.md (#3392) Publish Reorder publishing instructions Changelog for 1.0.16 (#3376) Update favicon description (#3374) Changelog for 1.0.15 (#3357) Replace template literal; fixes #3367 (#3368) CLI@1.4.2 Publish Add preflight CWD check for npm (#3355) Stop using `npm link` in tests (#3345) Fix for add .gitattributes file #3080 (#3122) Mention that start_url needs to be "." for client side routing start using npm-run-all to build scss and js (#2957) Updating the Service Worker opt-out documentation (#3108) Remove an useless negation in registerServiceWorker.js (#3150) Remove output.path from dev webpack config (#3158) Add `.mjs` support (#3239) Add documentation for Enzyme 3 integration (#3286) Make uglify work in Safari 10.0 - fixes #3280 (#3281) Fix favicon sizes value in manifest (#3287) Bump dependencies (#3342) recommend react-snap; react-snapshot isn't upgraded for React 16 (#3328) Update appveyor.cleanup-cache.txt Polyfill rAF in test environment (#3340) Use React 16 in development Use a simpler string replacement for the overlay Clarify the npm precompilation advice --no-edit Update `eslint-plugin-react` (#3146) Add jest coverage configuration docs (#3279) Update link to Jest Expect docs (#3303) Update README.md Fix dead link to Jest "expect" docs (#3289) v2.8.0 Use production React version for bundled overlay (#3267) Add warning when using `react-error-overlay` in production (#3264) Add external links to deployment services (#3265) `react-error-overlay` has no dependencies now (#3263) Add click-to-open support for build errors (#3100) Update style-loader and disable inclusion of its HMR code in builds (#3236) Update url-loader to 0.6.2 for mime ReDoS vuln (#3246) Make error overlay to run in the context of the iframe (#3142) Upgrade to typescript 2.5.3 Fix Windows compatibility (#3232) Fix package management link in README (#3227) Watch for changes in `src/**/node_modules` (#3230) More spec compliant HTML template (#2914) Minor change to highlight dev proxy behaviour (#3075) Correct manual proxy documentation (#3185) Improve grammar in README (#3211) Publish Fix license comments Changelog for 1.0.14 BSD+Patents -> MIT (#3189) Add link to active CSS modules discussion (#3163) Update webpack-dev-server to 2.8.2 (#3157) Part of class fields to stage 3 (#2908) Update unclear wording in webpack config docs (#3160) Display pid in already running message (#3131) Link local react-error-overlay package in kitchensink test Resolved issue #2971 (#2989) Revert "run npm 5.4.0 in CI (#3026)" (#3107) Updated react-error-overlay to latest Flow (0.54.0) (#3065) Auto-detect running editor on Linux for error overlay (#3077) Clean target directory before compiling overlay (#3102) Rerun prettier and pin version (#3058) ...

* Allow the dev server to watch for changes in src/node_modules * fix eslint error * fix broken regex * handle trailing slash edge case for file paths Closesreact#2760Fixesreact#3223

Allow the dev server to watch for changes in src/node_modules
80de217

facebook-github-bot added the CLA Signed label Oct 2, 2017

fix eslint error
b0ef885

fix broken regex
eca7cf0

handle trailing slash edge case for file paths
2d6875f

Timer added the tag: bug fix label Oct 3, 2017

Timer added this to the 1.0.15 milestone Oct 3, 2017

Timer merged commit 1e98d0f into react:masterOct 3, 2017

gaearon mentioned this pull request Oct 30, 2017
Changelog for 1.0.15 #3357
Merged

gaearon reviewed Oct 30, 2017
View reviewed changes

ghost mentioned this pull request Oct 31, 2017
7 packages updated by dependencies.io storybookjs/storybook#2200
Merged

This was referenced Feb 2, 2018
fix(deps): update dependency react-scripts to v1.1.5 - autoclosed SaraVieira/react-payment-request#17
Closed
Update dependency react-scripts to v1.1.1 - autoclosed kkostov/react-calendar-icon#32
Closed

lockBot locked and limited conversation to collaborators Jan 20, 2019

Uh oh!

Uh oh!

Conversation

xjlim commented Oct 2, 2017

Uh oh!

facebook-github-bot commented Oct 2, 2017

Uh oh!

facebook-github-bot commented Oct 2, 2017

Uh oh!

react-scripts-dangerous commented Oct 2, 2017

Uh oh!

Timer commented Oct 2, 2017

Uh oh!

xjlim commented Oct 3, 2017

Uh oh!

Timer commented Oct 3, 2017

Uh oh!

Timer commented Oct 3, 2017

Uh oh!

Timer commented Oct 3, 2017

Uh oh!

mariuskava commented Oct 3, 2017

Uh oh!

Timer commented Oct 3, 2017

Uh oh!

mariuskava commented Oct 3, 2017

Uh oh!

Timer commented Oct 3, 2017

Uh oh!

gaearonOct 30, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants