Uh oh!
There was an error while loading. Please reload this page.
Add README to generated project. - #33
Conversation
There was a problem hiding this comment.
I wanted to get some feedback on where we wanted to keep a README for the project itself.
I assume we don't want to just copy over the README from create-react-app but rather a README that takes the user's app name and just lists out some basic getting started instructions.
I was going to put it in the ./src but we're copying all of those files into the ./src of the project, so I'd have to end up checking for it and omitting it.
Any thoughts?
There was a problem hiding this comment.
Yeah, let's do a separate directory for host setup, and put another README there that is more practical (basically a howto document).
eanplatter
commented
Jul 20, 2016
Would it make sense to have all of the code that will be put into the user's project in one place? So instead of the following being in the root of the library: You have something more like this: That way when we're creating the user's files the method would be simpler, we can just |
vjeux
commented
Jul 20, 2016
Sounds like a good idea to me |
eanplatter
commented
Jul 20, 2016
ok, I'm working on a |
There was a problem hiding this comment.
Just as with the src directory, all of the files within the templateFiles directory will be put into the root of the project.
eanplatter
commented
Jul 20, 2016
Hey @gaearon any idea why this travis test is failing on node 4 but not 6? |
gaearon
commented
Jul 20, 2016
eanplatter
commented
Jul 20, 2016
Cool, should I hold off merging until this is fixed? |
gaearon
commented
Jul 20, 2016
Please do, I’m almost finished there. |
eanplatter
commented
Jul 20, 2016
No prob! |
gaearon
commented
Jul 20, 2016
You’re good to go now, sorry for the interruption! |
eanplatter
commented
Jul 20, 2016
Cool thanks, rebuilding now. I think this PR is to be reviewed |
There was a problem hiding this comment.
What do you think about moving src itself to templateFiles?
Also I’d prefer template to templateFiles.
There was a problem hiding this comment.
yeah I guess the template directory would be a good place for it, essentially a mirror of the default user app.
There was a problem hiding this comment.
If you go that way you’ll need to look for var relative = and adjust those paths.
There was a problem hiding this comment.
kk, thanks for the tip. I'll hop on this later today after work.
eanplatter
commented
Jul 21, 2016
eanplatter
commented
Jul 21, 2016
@gaearon sorry this took so long! I think it's ready now. |
| }); | ||
| copySync(path.join(selfPath, 'index.html'), path.join(hostPath, 'index.html')); | ||
| fs.readdirSync(path.join(selfPath, 'template')).forEach(function(filename) { | ||
| console.log('what even is this?', path.join(selfPath, 'template', filename)) |
There was a problem hiding this comment.
you probably don't want this log 😉
gaearon
commented
Jul 21, 2016
Thanks! |
eanplatter
commented
Jul 21, 2016
Thanks for putting up with me :) |
Local npm start and npm run build got broken by #33
Local npm start and npm run build got broken by #33

Fixes#29