Uh oh!
There was an error while loading. Please reload this page.
Re-enable yarn install on eject for non-windows machines - #3347
Closed
Timer wants to merge 16 commits into
Closed
Conversation
gaearon
previously requested changes
Oct 30, 2017
Contributor
There was a problem hiding this comment.
Let's do what I suggested in the other PR and instead just run npm and yarn to remove old dep and add new ones. I remember we didn't do it before because it was too slow with npm 2. Should be fine with modern versions. Also ejecting doesn't have to be super fast, it should be reliable.
ContributorAuthor
Sigh, "The batch file cannot be found." strikes again -- @xjlim do you know why this happens when Yarn is called via |
gaearon
commented
Nov 5, 2017
Contributor
Maybe need to add "cmd" like we do here? |
Timerforce-pushed
the
enable-yarn-again
branch
from
November 19, 2017 20:18
9a1ba30 to
9e7833cCompare
This was referenced Jan 15, 2018
gaearon
commented
Jan 16, 2018
Contributor
Fixed in #3806 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue three was fixed in July (yarnpkg/yarn#3811). 😄
Closes#2627.
Non-Windows users will no longer need to manually run Yarn after ejecting.