Uh oh!
There was an error while loading. Please reload this page.
Conversation
gaearonforce-pushed
the
document
branch
3 times, most recently
from
August 4, 2016 19:34
131b25b to
3246059Comparemxstbr
commented
Aug 4, 2016
Contributor
Ace. |
gaearonforce-pushed
the
document
branch
2 times, most recently
from
August 4, 2016 19:39
8717c0f to
6c47426Comparepawelgrzybek
commented
Aug 4, 2016
Great idea Dan. Yes please! |
gaearonforce-pushed
the
document
branch
3 times, most recently
from
August 4, 2016 19:47
c321146 to
a43fc43Compare| // { ...todo, completed: true } | ||
| require.resolve('babel-plugin-transform-object-rest-spread'), | ||
| require.resolve('babel-plugin-transform-react-constant-elements'), | ||
| // function* () { yield 42; yield 43; } |
There was a problem hiding this comment.
@gaearon what is this for? (just curious 💭 )
MoonTahoe
commented
Aug 4, 2016
I think this would be really a helpful point of reference for students. |
| require.resolve('babel-plugin-transform-class-properties'), | ||
| // { ...todo, completed: true } | ||
| require.resolve('babel-plugin-transform-object-rest-spread'), | ||
| require.resolve('babel-plugin-transform-react-constant-elements'), |
There was a problem hiding this comment.
this was the only non-comment change in this PR, is it intentional?
ContributorAuthor
There was a problem hiding this comment.
Yea, I just moved it a few lines down for consistency with dev config (order shouldn’t matter for this transform).
tizmagik added a commit
to tizmagik/create-react-app
that referenced
this pull request
Aug 5, 2016
…react-app * 'master' of https://github.com/facebookincubator/create-react-app: 0.3.0-alpha Update some deps Document configuration and build process (react#362) # Conflicts: # config/webpack.config.dev.js
gaearon added a commit
that referenced
this pull request
Aug 22, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like a nice thing to do since the user will have to deal with this after ejection.
Also serves as a good reminder for us in the future for why we made certain choices.