Skip to content

Add cache busting for the service worker so it works correctly for more people by default#3761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anshul wants to merge 1 commit into from
Closed

Add cache busting for the service worker so it works correctly for more people by default #3761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react-scripts/template/src/registerServiceWorker.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,9 @@ export default function register() {
}

window.addEventListener('load', () => {
const swUrl = `${process.env.PUBLIC_URL}/service-worker.js`;
// Avoid service worker caching issues.
const noCache = new Date() * 1;
const swUrl = `${process.env.PUBLIC_URL}/service-worker.js?nocache=${noCache}`;

if (isLocalhost) {
// This is running on localhost. Lets check if a service worker still exists or not.
Expand Down