Skip to content

Loosen Babel preset to use browserslist - #3770

Merged
Timer merged 6 commits into
react:nextfrom
Timer:target-browsers
Jan 13, 2018
Merged

Loosen Babel preset to use browserslist#3770
Timer merged 6 commits into
react:nextfrom
Timer:target-browsers

Conversation

@Timer

@TimerTimer commented Jan 13, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

This removes the ie 9 target and forceAllTransforms since we're dropping IE9 support by default.

We want to allow target browsers to be configurable via the browserslist key in package.json.
This also enables useBuiltIns for smaller bundles.

I've also adjusted the defaults we generate for a more ergonomic development experience.

There's still no story for users upgrading from * -> 2.x (it'd use browserlist defaults currently).

@TimerTimer changed the title Loosen Babel preset to use browsersLoosen Babel preset to use browserslistJan 13, 2018
@TimerTimer added this to the 2.0.0 milestone Jan 13, 2018
@Timer

Timer commented Jan 13, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Meh, why not? Commits can be reverted (and follow-up PRs made) -- this will be fun to play with in the meantime.

:shipit: 🚀

@Timer
Timer merged commit 2e4e4db into react:nextJan 13, 2018
@Timer
Timer deleted the target-browsers branch January 13, 2018 03:49
@Timer
Timer requested a review from gaearonJanuary 13, 2018 03:49
@TimerTimer mentioned this pull request Jan 13, 2018
Closed
gaearon
gaearon reviewed Jan 13, 2018
View reviewed changes
Comment threadpackages/react-scripts/scripts/init.js
];
appPackage.browserslist = {
development: ['chrome', 'firefox', 'edge'].map(
browser => `last 2 ${browser} versions`

@gaearongaearonJan 13, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? Does this correspond to any specific list we use elsewhere?

@gaearongaearonJan 13, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I got it.
Wish there was a shorter way to write this.
Maybe something like >5% is equivalent?

@TimerTimerJan 13, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a magic percent -- and I didn't want to discriminate browsers.

@gaearon

gaearon commented Jan 13, 2018

Copy link
Copy Markdown
Contributor

Can you describe how this works in more detail?

In particular, what happens if I write ES6 code and then set browserslist to last chrome version for production? We still use old Uglify (afaik). So does Uglify just crash on App.js class?

@gaearon

gaearon commented Jan 13, 2018

Copy link
Copy Markdown
Contributor

Or do we use new Uglify now?

@existentialism

existentialism commented Jan 13, 2018

Copy link
Copy Markdown
Contributor

Yep via #3618 and #3743

@TimerTimer mentioned this pull request Jan 13, 2018
Closed
gaearon pushed a commit that referenced this pull request Jan 13, 2018
@Timer@gaearon
Loosen Babel preset to use browserslist (#3770)
6b2454e
* Provide better defaults
* Let babel determine features to compile
* meh
* Remove setting of BABEL_ENV
* Revert "Remove setting of BABEL_ENV"
This reverts commit ee2db70.
* Set browsers to ie9
Timer added a commit that referenced this pull request Jan 14, 2018
@Timer
Loosen Babel preset to use browserslist (#3770)
5580c97
* Provide better defaults
* Let babel determine features to compile
* meh
* Remove setting of BABEL_ENV
* Revert "Remove setting of BABEL_ENV"
This reverts commit ee2db70.
* Set browsers to ie9
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@Timer@gaearon
Loosen Babel preset to use browserslist (#3770)
a5bfd18
* Provide better defaults
* Let babel determine features to compile
* meh
* Remove setting of BABEL_ENV
* Revert "Remove setting of BABEL_ENV"
This reverts commit ee2db70.
* Set browsers to ie9
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@Timer@gaearon
Loosen Babel preset to use browserslist (#3770)
d869461
* Provide better defaults
* Let babel determine features to compile
* meh
* Remove setting of BABEL_ENV
* Revert "Remove setting of BABEL_ENV"
This reverts commit ee2db70.
* Set browsers to ie9
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@Timer@gaearon
Loosen Babel preset to use browserslist (#3770)
eb1b921
* Provide better defaults
* Let babel determine features to compile
* meh
* Remove setting of BABEL_ENV
* Revert "Remove setting of BABEL_ENV"
This reverts commit ee2db70.
* Set browsers to ie9
gaearon pushed a commit that referenced this pull request Jan 14, 2018
@Timer@gaearon
Loosen Babel preset to use browserslist (#3770)
2646ed1
* Provide better defaults
* Let babel determine features to compile
* meh
* Remove setting of BABEL_ENV
* Revert "Remove setting of BABEL_ENV"
This reverts commit ee2db70.
* Set browsers to ie9
Timer added a commit to Timer/create-react-app that referenced this pull request Jan 15, 2018
@Timer
Loosen Babel preset to use browserslist (react#3770)
aa67a4f
* Provide better defaults
* Let babel determine features to compile
* meh
* Remove setting of BABEL_ENV
* Revert "Remove setting of BABEL_ENV"
This reverts commit ee2db70.
* Set browsers to ie9
@gaearongaearon mentioned this pull request Jan 16, 2018
Closed
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
@Timer@akstuhl
Loosen Babel preset to use browserslist (react#3770)
d4c1e63
* Provide better defaults
* Let babel determine features to compile
* meh
* Remove setting of BABEL_ENV
* Revert "Remove setting of BABEL_ENV"
This reverts commit ee2db70.
* Set browsers to ie9
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@Timer
Loosen Babel preset to use browserslist (react#3770)
2bfa72c
* Provide better defaults
* Let babel determine features to compile
* meh
* Remove setting of BABEL_ENV
* Revert "Remove setting of BABEL_ENV"
This reverts commit ee2db70.
* Set browsers to ie9
@locklockBot locked and limited conversation to collaborators Jan 20, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@gaearongaearongaearon left review comments
@existentialismexistentialismexistentialism approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: enhancement

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Timer@gaearon@existentialism@facebook-github-bot