Uh oh!
There was an error while loading. Please reload this page.
multipackage monorepo base configuration - #405
Conversation
facebook-github-bot
commented
Aug 8, 2016
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
ryanyogan
commented
Aug 8, 2016
I'll fix that travis explosion |
ghost
commented
Aug 8, 2016
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ryanyogan
commented
Aug 8, 2016
@gaearon I'm having a little trouble with the e2e, did I mess something up something obvious I am missing? |
| @@ -34,11 +34,11 @@ function resolveApp(relativePath) { | |||
| if (isInCreateReactAppSource) { | |||
| // create-react-app development: we're in ./config/ | |||
There was a problem hiding this comment.
Need to change this comment: we’re in ./packages/react-scripts/config
gaearon
commented
Aug 8, 2016
Try running |
Monorepo basic configuration in reference to #403
Changes made to directory structure
|- packages (new root directory)
|-- create-react-app (was parent directory)
|-- react-scripts (was global-cli)
Testing
To test as you would use
npm i create-react-app -gcd packages/create-react-app && npm i . -gto install locally ornpm linkcreate-react-app my-appshould work as beforeTo test the build process
cd packages/react-scripts && npm i && npm run buildNotes
This is just the directory structure changes, perhaps a little discussion around @hzoo's comment regarding Lerna Independant is warranted?