Skip to content

Fix #316 Add React Native Web support - #407

Merged
gaearon merged 1 commit into
react:masterfrom
grigio:master
Aug 9, 2016
Merged

Fix #316 Add React Native Web support#407
gaearon merged 1 commit into
react:masterfrom
grigio:master

Conversation

@grigio

Copy link
Copy Markdown
Contributor

See #316

@ghostghost added the CLA Signed label Aug 9, 2016
@gaearon

Copy link
Copy Markdown
Contributor

Thanks! Have you tested it? Can you show a screenshot of what it's like?

@grigio

Copy link
Copy Markdown
ContributorAuthor

@gaearon I've tested that change in my eject(ed) create-react-app in dev and prod mode

@ghostghost added the CLA Signed label Aug 9, 2016
@gaearon

Copy link
Copy Markdown
Contributor

But it doesn't require ejecting, does it? Can you test this in the CRA repo? You can run npm start right in it.

@grigio

Copy link
Copy Markdown
ContributorAuthor

Yes without eject now. Tested in my CRA repo fork with npm start

@grigio

Copy link
Copy Markdown
ContributorAuthor

schermata 2016-08-09 alle 12 38 02

@gaearon
gaearon merged commit 623e1bd into react:masterAug 9, 2016
@gaearon

Copy link
Copy Markdown
Contributor

Nice, thanks.

gaearon pushed a commit that referenced this pull request Aug 22, 2016
@gaearongaearon added this to the 0.2.2 milestone Aug 22, 2016
@gaearongaearon mentioned this pull request Aug 22, 2016
stayradiated pushed a commit to stayradiated/create-react-app that referenced this pull request Sep 7, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@locklockBot locked and limited conversation to collaborators Jan 22, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@grigio@gaearon