Skip to content

Preserve quotes in font values during minification - #4122

Closed
veltman wants to merge 1 commit into
react:masterfrom
veltman:next
Closed

Preserve quotes in font values during minification#4122
veltman wants to merge 1 commit into
react:masterfrom
veltman:next

Conversation

@veltman

@veltmanveltman commented Mar 7, 2018

Copy link
Copy Markdown

Closes#4121.

@facebook-github-bot

facebook-github-bot commented Mar 7, 2018

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Mar 7, 2018

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@TimerTimer added this to the 2.0.0 milestone Mar 8, 2018
@Timer

Timer commented Mar 8, 2018

Copy link
Copy Markdown
Contributor

@veltman just letting you know I'm going to sit on this for a while before merging as we figure out a final patch release for 1.x.

@iansu

iansu commented Mar 8, 2018

Copy link
Copy Markdown
Contributor

Should we update this PR to target master instead of next then?

@TimerTimer closed this Sep 26, 2018
@TimerTimer reopened this Sep 26, 2018
@TimerTimer modified the milestones: 2.0.x, 2.xSep 26, 2018
@gaearongaearon closed this Nov 1, 2018
@Timer
Timer changed the base branch from next to masterJanuary 8, 2019 00:38
@TimerTimer modified the milestones: 2.x, 2.1.xJan 8, 2019
@TimerTimer reopened this Jan 8, 2019
@TimerTimer modified the milestones: 2.1.x, 2.1.4Jan 8, 2019
@ianschmitzianschmitz modified the milestones: 2.1.4, 2.1.5Feb 10, 2019
@iansuiansu modified the milestones: 2.1.6, 2.1.x, 3.xMar 6, 2019
@heyimalex

heyimalex commented Dec 13, 2019

Copy link
Copy Markdown
Contributor

Should be closed by #8106?

@locklockBot locked and limited conversation to collaborators Dec 18, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pmouraopmouraopmourao approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: bug fix

Projects

None yet

Milestone

5.x

Development

Successfully merging this pull request may close these issues.

Prod config produces invalid font-family values in minified CSS

8 participants

@veltman@facebook-github-bot@Timer@iansu@heyimalex@pmourao@gaearon@ianschmitz