Skip to content

Support package distribution tags - #4350

Merged
Timer merged 4 commits into
react:nextfrom
miraage:miraage/gh-4348
Apr 27, 2018
Merged

Support package distribution tags#4350
Timer merged 4 commits into
react:nextfrom
miraage:miraage/gh-4348

Conversation

@miraage

@miraagemiraage commented Apr 24, 2018•
edited
Loading

Copy link
Copy Markdown

Tested via npm link on OSX with npm@5.8.0 and yarn@1.6.0

Closes#4348

@miraagemiraage changed the title Support package distribution tags (#4348)Support package distribution tagsApr 24, 2018
@miraage

miraage commented Apr 24, 2018•
edited
Loading

Copy link
Copy Markdown
Author

@Timer how could I trigger re-run for CI? Seems like Travis was not able to finish tests in time:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

@Timer

Timer commented Apr 24, 2018

Copy link
Copy Markdown
Contributor

I retriggered it, but can you please add a test for this to e2e-installs?

@TimerTimer added this to the 2.0.0 milestone Apr 24, 2018
@miraage

miraage commented Apr 25, 2018

Copy link
Copy Markdown
Author

Any idea why npm run e2e:docker fails upon publishing packages to the local registry?

@iansu

iansu commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

If you're talking about running the docker e2e tests locally then that's a known issue. They haven't been working properly for a while.

@miraage

miraage commented Apr 25, 2018

Copy link
Copy Markdown
Author

@iansu thank you for clarification. I struggle to find the reasons of build failures.
I doublechecked every line of code I changed and still can't figure out what might cause a fail.
Any chance you could point me mistakes I made?

Travis: same errors as I wrote above.

AppVeyor:

error An unexpected error occurred: "http://localhost:4873/react-scripts-fork/-/react-scripts-fork-0.4.3.tgz: unexpected end of file

@iansuiansu mentioned this pull request Apr 25, 2018
Merged
@miraagemiraage closed this Apr 27, 2018
@miraagemiraage reopened this Apr 27, 2018
@miraage

miraage commented Apr 27, 2018•
edited
Loading

Copy link
Copy Markdown
Author

Closed/opened to trigger CI.

@miraage

miraage commented Apr 27, 2018

Copy link
Copy Markdown
Author

@Timer here we go :)

@Timer

Timer commented Apr 27, 2018

Copy link
Copy Markdown
Contributor

Awesome! Thanks much.

@Timer
Timer merged commit da4a87f into react:nextApr 27, 2018
@miraage
miraage deleted the miraage/gh-4348 branch April 27, 2018 14:57
kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request May 2, 2018
@kellyrmilligan
Merge remote-tracking branch 'upstream/next' into next
b021bb4
* upstream/next: (35 commits)
Update envinfo and issue template (react#4375)
Update sass-loader to 7.0.1 (react#4376)
Support package distribution tags (react#4350)
fix broken css module support in prod (react#4361)
Bumped jest version to 22.4.1 (react#4362)
bump babel 7 to beta 46
bump lint-staged to node 10 compatible version
documentation: Added License to the README.md (react#4294)
Bump `fsevents`. (react#4331)
Fix typo in e2e-simple.sh comment (react#4323)
Add Sass loader (react#4195)
Fix some typos in README.md (react#4286)
Added learnstorybook.com to Storybook links (react#4298)
Document multiple build environments via `env-cmd` react#4071 (react#4117)
Fixed link to CSS imports blog post
Update CSS Modules localIndetName (react#4192)
Enable loose mode for `class-properties` (react#4248)
bump babel 7 beta (react#4253)
Small typo fixreact#4217
Changelog for 1.1.4
...
kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request May 2, 2018
@kellyrmilligan
Merge branch 'next' into feature/serve-app-under-homepage
af16a17
* next: (35 commits)
Update envinfo and issue template (react#4375)
Update sass-loader to 7.0.1 (react#4376)
Support package distribution tags (react#4350)
fix broken css module support in prod (react#4361)
Bumped jest version to 22.4.1 (react#4362)
bump babel 7 to beta 46
bump lint-staged to node 10 compatible version
documentation: Added License to the README.md (react#4294)
Bump `fsevents`. (react#4331)
Fix typo in e2e-simple.sh comment (react#4323)
Add Sass loader (react#4195)
Fix some typos in README.md (react#4286)
Added learnstorybook.com to Storybook links (react#4298)
Document multiple build environments via `env-cmd` react#4071 (react#4117)
Fixed link to CSS imports blog post
Update CSS Modules localIndetName (react#4192)
Enable loose mode for `class-properties` (react#4248)
bump babel 7 beta (react#4253)
Small typo fixreact#4217
Changelog for 1.1.4
...
@locklockBot locked and limited conversation to collaborators Jan 20, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signedtag: new feature

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@miraage@Timer@iansu@facebook-github-bot