Skip to content

add react-testing-library documentation/examples - #4679

Merged
Timer merged 3 commits into
react:masterfrom
kentcdodds:patch-1
Jun 26, 2018
Merged

add react-testing-library documentation/examples#4679
Timer merged 3 commits into
react:masterfrom
kentcdodds:patch-1

Conversation

@kentcdodds

Copy link
Copy Markdown
Contributor

Rendered: https://github.com/kentcdodds/create-react-app/blob/1b3a028f0dea697322a2e85906c7642f357313c6/packages/react-scripts/template/README.md#use-react-testing-library

Considering the growing popularity of react-testing-library, it seems fitting to document and provide examples of using this library for folks looking for a testing utility that matches their preferences.

@Timer

Copy link
Copy Markdown
Contributor

Thanks! Small nit, fix "assertsions".

@TimerTimer added this to the 2.0.0 milestone Jun 26, 2018
@kentcdodds

Copy link
Copy Markdown
ContributorAuthor

Done 👍

@Timer

Copy link
Copy Markdown
Contributor

Awesome!

@Timer
Timer merged commit ea7b374 into react:masterJun 26, 2018
@kentcdodds
kentcdodds deleted the patch-1 branch June 26, 2018 16:46
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
* add react-testing-library documentation/examples
* make react-testing-library a heading
* fix typo
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018
* add react-testing-library documentation/examples
* make react-testing-library a heading
* fix typo
cloud-walker pushed a commit to cloud-walker/create-react-app that referenced this pull request Aug 27, 2018
* Add modes to our Babel preset (1.x) (react#4668)
* babel-preset-react-app@3.1.2
* add react-testing-library documentation/examples (react#4679)
* add react-testing-library documentation/examples
* make react-testing-library a heading
* fix typo
* Fix link to the article about BEM (react#4858)
* Use file name whitelist to prevent RCE (react#4866)
* Use file name whitelist to prevent RCE
Use a whitelist to validate user-provided file names. This doesn't cover
the entire range of valid filenames but should cover almost all of them
in practice. Allows letters, numbers, periods, dashes, and underscores.
Opting to use a whitelist instead of a blacklist because getting this
wrong leaves us vulnerable to a RCE attack.
* Allow alphabet characters from all languages
Updated the whitelist to /^[\p{L}0-9/.\-_]+$/u, which matches
alphanumeric characters, periods, dashes, and underscores. Unicode
property support is stage 4 so I've inlined the transpiled version.
* Only use file name whitelist on Windows
* Log error message if file name does not pass whitelist
* Bump versions
* Bump release
* Add 1.1.5 release notes
@gnapse

Copy link
Copy Markdown
Contributor

This is lost somehow now. Not present in master anymore :(

@Timer

Timer commented Oct 4, 2018

Copy link
Copy Markdown
Contributor

No clue where it went. Can someone resubmit please?

@gnapse

Copy link
Copy Markdown
Contributor

I'm pretty sure it was in this merge commit: 4562ab6

I'll create a new PR to add it back.

@Timer

Timer commented Oct 4, 2018

Copy link
Copy Markdown
Contributor

Ah, I didn't realize this was merged into master and not next. Yes. We blew away all stuff in master in favor of next branch.

Timer pushed a commit that referenced this pull request Oct 4, 2018
* add react-testing-library documentation/examples
* make react-testing-library a heading
* fix typo
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
…5290)
* add react-testing-library documentation/examples
* make react-testing-library a heading
* fix typo
@locklockBot locked and limited conversation to collaborators Jan 18, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kentcdodds@Timer@gnapse@facebook-github-bot