Uh oh!
There was an error while loading. Please reload this page.
feat: update svgr/webpack loader - #4799
Conversation
facebook-github-bot
commented
Jul 20, 2018
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Jul 20, 2018
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
gregberge
commented
Aug 13, 2018
Upgrading to SVGR 2 should reduce dependency size. It is a major including a lot of breaking changes (especially the support of runtime configurations). That's why I think upgrading it before releasing create-react-app 2.0 is very important. |
Timer
commented
Sep 21, 2018
This is waiting on gregberge/svgr#179 |
Timer
commented
Sep 21, 2018
Also, we need to disable |
Timer
commented
Sep 21, 2018
gregberge
commented
Sep 22, 2018
There is one more thing. SVGR latest requires the latest version of JSDOM, but it could work with the previous one. We should check if bundle size is not impacted by two versions of JSDOM (one for Jest and one for SVGR). |
gregberge
commented
Oct 1, 2018
SVGR v3 is out! You can now set |
Timer
commented
Oct 1, 2018
Neat, @neoziro! Thanks for the update. It'd be really neat if the packages handling configuration, optimizing, and prettifying svgs could be decoupled from the main package so we're not bloating the dependency tree. |
gregberge
commented
Oct 1, 2018
@Timer I think it is already decoupled enough, "@svgr/core", "@svgr/cli", "@svgr/webpack"... I will not decouple it more. |
This PR replaces
svgr/webpackloader with its latest version available in@svgr/webpackpackage.The change solves #4798.
I tested this code change locally and it now reads custom config from i.e.
.svgorc.jsonfile (placed in the project root directory).