Skip to content

Enable eval-source-map for firefox - #5060

Merged
Timer merged 1 commit into
react:masterfrom
jasonLaster:ff
Jan 7, 2019
Merged

Enable eval-source-map for firefox#5060
Timer merged 1 commit into
react:masterfrom
jasonLaster:ff

Conversation

@jasonLaster

@jasonLasterjasonLaster commented Sep 21, 2018

Copy link
Copy Markdown
Contributor

Follow up for #4930.

This enables eval-source-map for firefox browsers, which makes it possible to see mapped scopes and variables. Hopefully in a couple of months chrome will also support eval-source-map and we can drop the check.

@TimerTimer closed this Sep 26, 2018
@TimerTimer reopened this Sep 26, 2018
@gaearongaearon closed this Nov 1, 2018
@Timer
Timer changed the base branch from next to masterNovember 1, 2018 17:11
@TimerTimer reopened this Nov 1, 2018
@stale

staleBot commented Dec 1, 2018

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Dec 1, 2018
@Timer

Timer commented Dec 1, 2018

Copy link
Copy Markdown
Contributor

Stale be gone!

@stalestaleBot removed the stale label Dec 1, 2018
@jasonLaster

jasonLaster commented Dec 3, 2018

Copy link
Copy Markdown
ContributorAuthor

@Timer should we rebase and try to land?

It seems like chrome is unblocked...

@Timer

Timer commented Dec 3, 2018

Copy link
Copy Markdown
Contributor

Yeah, I think it's about time to switch to this by default.

@stale

staleBot commented Jan 2, 2019

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Jan 2, 2019
Jason Laster
Switch to eval-source-map
09b9c2f
Switches to eval-source-map, which is easier for webpack to recompute
when a file changes and has column based mappings, which lets firefox
devtools show original variable in the debugger and evaluate original
expressions in the console.
@jasonLaster

jasonLaster commented Jan 3, 2019

Copy link
Copy Markdown
ContributorAuthor

hmm, seeing some build errors

+yarn build
yarn run v1.14.0-20181221.0548
$ node scripts/build.js
Creating an optimized production build...
Failed to compile.
./src/index.js
Error: [BABEL] /tmp/tmp.jilV9AKxMW/test-app/src/index.js: Cannot find module '@babel/plugin-transform-react-jsx' (While processing: "/tmp/tmp.jilV9AKxMW/test-app/node_modules/babel-preset-react-app/index.js$1")
at Array.reduce (<anonymous>)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
++set +x
e2e-simple.sh: ERROR! An error was encountered executing line 273.
Cleaning up.
yarn config v1.14.0-20181221.0548
success Set "registry" to "https://registry.yarnpkg.com".
Exiting with error.
The command "if [ $TEST_SUITE = "simple" ]; then tasks/e2e-simple.sh; fi" exited with 1.

@stalestaleBot removed the stale label Jan 3, 2019
@TimerTimer added this to the 2.1.3 milestone Jan 3, 2019
@Timer

Timer commented Jan 3, 2019

Copy link
Copy Markdown
Contributor

I tagged this for next release so it stops falling through the cracks :-)

@robertvansteen

robertvansteen commented Jan 3, 2019

Copy link
Copy Markdown
Contributor

@jasonLaster that error is also on master. Not sure what's going on.

@ianschmitzianschmitz modified the milestones: 2.1.3, 2.1.4Jan 4, 2019
@ianschmitzianschmitz reopened this Jan 7, 2019
@jasonLaster

jasonLaster commented Jan 7, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@ianschmitz thanks for the bump.
@Timer looks like we're 🌴

@Timer

Timer commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

:shipit: YOLO

@Timer
Timer merged commit 773d103 into react:masterJan 7, 2019
@Timer

Timer commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

Thanks @jasonLaster for all the time you spent on this, including our pair-programming! It was a pleasure working with you.

@locklockBot locked and limited conversation to collaborators Jan 12, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signedtag: enhancement

Projects

None yet

Milestone

2.1.4

Development

Successfully merging this pull request may close these issues.

6 participants

@jasonLaster@Timer@robertvansteen@gaearon@ianschmitz@facebook-github-bot