Don't polyfill fetch for Node

[Timer]

Fixes#5124

Should we use isomorphic-fetch? Or leave this up to the user since using the Node test environment is "advanced"?

[gaearon]

We used to always import it. Does that cause a problem? Is it broken in Node anyway? In that case I'd be fine with not supporting it there. On the other hand, shouldn't we expect jsdom to add it at some point? In that case it would make sense to polyfill it in Node. At least when jsdom is on.

[Timer]

It's currently broken in Node. In v1, the polyfills were a webpack entrypoint not a Jest setup file, so this didn't bite us until now.

[lixiaoyan]

FYI isomorphic-fetch is no longer under maintenance, universal-fetch is the active fork.

[Timer]

Last universal published 2 years ago, 3 for isomorphic.

What about cross-fetch? Seems to be published within 3 months.

[Timer]

Hmm, cross-fetch uses their own impl under the hood instead of whatwg-fetch, I don't like that.

[gaearon]

It's currently broken in Node. In v1, the polyfills were a webpack entrypoint not a Jest setup file, so this didn't bite us until now.

OK

[gaearon]

Wait. Polyfills were an entry point in Jest. How else could we get rAF there?

[Timer]

Oh, you're right... 🤔 I'll dig more into this, maybe it never worked and that many people left on the jsdom environment?

[gaearon]

No idea.

My high level feedback is: if it was broken before I'd just remove it. If it kinda worked before, I'd leave it in the same state as it was. It should always be removed in non-jsdom environment.

I probably wouldn't add something like universal-fetch without more people asking for it. In tests you don't really want fetching to work. You usually want to mock it.

[Timer]

It should always be removed in non-jsdom environment.

Well, right now Jest can't even load when using the Node env and this at least allows tests to run again.

I assume people must've mocked out fetch before us trying to import it, but I think this is a better default.

[Timer]

Ah, found it. whatwg-fetch v2 would decorate global (self, fallback to this). v3 seems to have stricter protections to make sure it's only used in context of a browser.

[Timer]

Actually, this might be a bug: JakeChampion/fetch#657

But we still probably want the behavior of this PR by default.

[gshilin]

The same fix should be also merged to ie9.js and ie11.js

[Timer]

Feel free to send PR.