Skip to content

Run behavioral smoke tests with Jest, add output tests - #5150

Merged
Timer merged 12 commits into
react:masterfrom
Timer:better-testing
Sep 28, 2018
Merged

Run behavioral smoke tests with Jest, add output tests#5150
Timer merged 12 commits into
react:masterfrom
Timer:better-testing

Conversation

@Timer

@TimerTimer commented Sep 28, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR runs behavioral tests via Jest, follow up to #5146.

updates Smoke tests:

  1. smoke test SCSS support with Bootstrap
  2. smoke test @babel/runtime support across major versions, within application and dependencies

adds (true) Output tests:

  1. babel syntax error
  2. css syntax error / broken
  3. missing export / erratic behavior
  4. module not found / suboptimal
  5. eslint warning
  6. eslint error

@TimerTimer added this to the 2.0.0 milestone Sep 28, 2018
@Timer
Timer requested a review from gaearonSeptember 28, 2018 08:35
gaearon
gaearon reviewed Sep 28, 2018
View reviewed changes
Comment threadfixtures/output/webpack-message-formatting/index.test.js
if (sizeIndex !== -1) {
response.stdout = response.stdout.substring(0, sizeIndex);
}
expect(response).toMatchSnapshot();

@gaearongaearonSep 28, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG this is so great. 😍😍😍

@TimerTimer changed the title Run behavioral smoke tests with JestRun behavioral smoke tests with Jest, add output testsSep 28, 2018
@Timer
Timer merged commit 2a7346e into react:masterSep 28, 2018
@Timer

Timer commented Sep 28, 2018

Copy link
Copy Markdown
ContributorAuthor

Givin' myself the enhancement label on this one, too.

@Timer
Timer deleted the better-testing branch September 28, 2018 10:19
@locklockBot locked and limited conversation to collaborators Jan 19, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@gaearongaearongaearon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: enhancementtag: internal

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Timer@gaearon@facebook-github-bot