Uh oh!
There was an error while loading. Please reload this page.
Removing unnecessary spread plugin proposal since it's in @babel@7 - #5331
Removing unnecessary spread plugin proposal since it's in @babel@7#5331assuncaocharles wants to merge 4 commits into
Conversation
facebook-github-bot
commented
Oct 6, 2018
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Oct 6, 2018
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
assuncaocharles
commented
Oct 6, 2018
I see that trevis is failing to run e2e-installs.sh, what locally runs just fine. Any idea what should be done here? |
Timer
commented
Oct 6, 2018
We should probably add a E2E test with the old regression test to make sure this doesn't break again. |
This reverts commit 8380b25.
Timer
commented
Oct 8, 2018
This behavior still seems buggy, see unreleased patch to fix these interactions: babel/babel#8793 |
ianschmitz
commented
Nov 4, 2018
Looks like this was released as part of v7.1.3 |
Timer
commented
Nov 4, 2018
Unfortunately, I still don't trust that this works correctly. There's zero harm in including this plugin to be safe, so let's leave it for now. Thanks for your contribution! |
Related to the issue #5310 that's a correct observation since
"@babel/core": "7.1.0"is already a dependency make this plugin unnecessary.https://babeljs.io/blog/2018/08/27/7.0.0#tc39-proposals-https-githubcom-tc39-proposals-support