Skip to content

Check if config callbacks are defined before using them (next) - #5368

Closed
piotr-cz wants to merge 1 commit into
react:nextfrom
piotr-cz:bugfix/sw-callbacks
Closed

Check if config callbacks are defined before using them (next)#5368
piotr-cz wants to merge 1 commit into
react:nextfrom
piotr-cz:bugfix/sw-callbacks

Conversation

@piotr-cz

@piotr-czpiotr-cz commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

This resolves bug introduced and reported in #3867:

Before invoking callbacks onUpdate and onSuccess, there should be check to make sure that config object has been passed to service worker at all.

@piotr-czpiotr-cz mentioned this pull request Oct 9, 2018
Merged
@piotr-czpiotr-cz changed the title Check if config callbacks are defined before using themCheck if config callbacks are defined before using them (next)Oct 9, 2018
@piotr-cz

piotr-cz commented Oct 9, 2018

Copy link
Copy Markdown
ContributorAuthor

Travis fails with message: lerna ERR! Error: fatal: No tags can describe '1feca43dbdba5f21e52acb629a601870a4d0a0dc'..

@Timer
Timer changed the base branch from next to masterOctober 9, 2018 12:19
@Timer

Timer commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

Fix was fixed previously via #5301, thanks!

@TimerTimer closed this Oct 9, 2018
@piotr-cz

piotr-cz commented Oct 9, 2018

Copy link
Copy Markdown
ContributorAuthor

Thanks, I didn't notice. However this one is for next branch

@piotr-cz
piotr-cz changed the base branch from master to nextOctober 9, 2018 13:41
@piotr-cz

piotr-cz commented Oct 9, 2018

Copy link
Copy Markdown
ContributorAuthor

Okay, I've changed base branch from master to next (I was sure I've done when opening PR)

@Timer

Timer commented Oct 9, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

next isn't a valid branch anymore. We're back on master, I had switched it for you.

@piotr-cz

piotr-cz commented Oct 9, 2018

Copy link
Copy Markdown
ContributorAuthor

Thanks, I didn't know

@piotr-cz
piotr-cz deleted the bugfix/sw-callbacks branch October 9, 2018 20:12
@locklockBot locked and limited conversation to collaborators Jan 18, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piotr-cz@Timer@facebook-github-bot