Uh oh!
There was an error while loading. Please reload this page.
Add allowESModules option to babel-preset-react-app - #5487
Conversation
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Pajn
commented
Nov 18, 2018
Bump? |
Timer
left a comment
There was a problem hiding this comment.
I think it'd be better to use the already-existing variable name. What do you think?
| var isEnvProduction = env === 'production'; | ||
| var isEnvTest = env === 'test'; | ||
| var allowESModules = validateBoolOption('allowESModules', opts.allowESModules, true); |
There was a problem hiding this comment.
Let's make this default to isEnvDevelopment || isEnvProduction and use the existing name.
| varallowESModules=validateBoolOption('allowESModules',opts.allowESModules,true); | |
| varuseESModules=validateBoolOption('useESModules',opts.useESModules,isEnvDevelopment||isEnvProduction); |
| // We should turn this on once the lowest version of Node LTS | ||
| // supports ES Modules. | ||
| useESModules: isEnvDevelopment || isEnvProduction, | ||
| useESModules: allowESModules ? isEnvDevelopment || isEnvProduction : false, |
There was a problem hiding this comment.
Consequently, this becomes simpler (or use the shorthand syntax):
| useESModules: allowESModules ? isEnvDevelopment||isEnvProduction : false, | |
| useESModules: useESModules, |
Pajn
commented
Nov 19, 2018
Seams reasonable, updated to match requested changes. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Pajn <rasmus@eneman.eu>
Pajn
commented
Nov 20, 2018
I misunderstood and thought you ment only the varaible name, but that's an easy fix |
Timer
commented
Nov 20, 2018
I think this behavior is best -- if undefined, it uses old (reasonable) logic. If the user defines it, uses that value. Does this seem good to you? |
Pajn
commented
Nov 21, 2018
Absolutely, It's even cleaner code. 👍 |
* upstream/master: (210 commits) Support setupTests.ts (react#5698) Remove unnecessary whitespace in template HTML Run prettier on HTML files (react#5839) Some Grammar fixes (react#5858) Fix link to page about running tests (react#5883) fix: make typescriptformatter support 0.5 of fork checker (react#5879) Always test with the latest stable Node version on Travis (react#5546) Fix propertyDecorator test Upgrade babel deps Fix annotated var test Fix TypeScript decorator support (react#5783) fix: add `sideEffects: false` to react-error-overlay (react#5451) Add allowESModules option to babel-preset-react-app (react#5487) Make named-asset-import plugin work with export-as syntax (react#5573) React native repository updated in README.md (react#5849) extra polyfills must be included manually (react#5814) Rename 'getting started' link to 'docs' (react#5806) docs: Simplify installing Storybook with npx (react#5788) Don't polyfill fetch for Node -- additional files (react#5789) docs: Change Storybook install documentation (react#5779) ...
Please see the discussion in #5452