Skip to content

add tests for named-asset-imports plugin#5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iansu merged 8 commits into from
Oct 31, 2018
Merged

add tests for named-asset-imports plugin #5575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e78928a
add tests for named-asset-imports plugin
NShahri Oct 26, 2018
fc8b25b
add ticketFormats store/saga
NShahri Oct 28, 2018
3086cf5
Merge branch 'master' of github.com:facebook/create-react-app into na…
NShahri Oct 31, 2018
3af34d5
change import to require on test file to avoid using babel when runni…
NShahri Oct 31, 2018
7f89098
remove all babel dependencies as not needed more for running tests
NShahri Oct 31, 2018
148d828
update tests and rename file to index.test.js
NShahri Oct 31, 2018
d6c7d36
remove npmignore as it is whitelisted in package.json
NShahri Oct 31, 2018
e2c4115
add babel-plugin-named-asset-import tests to e2e
NShahri Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions packages/babel-plugin-named-asset-import/index.test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
const pluginTester = require('babel-plugin-tester');
const namedAssetImport = require('./index');

pluginTester({
plugin: namedAssetImport,
pluginOptions: {
loaderMap: {
svg: {
ReactComponent: '@svgr/webpack?-prettier,-svgo![path]',
},
},
},
pluginName: 'named-asset-import',
snapshot: false,
tests: {
defaultImport: {
code: 'import logo from "logo";',

@iansuiansuOct 31, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason these don't include the file name? Why not import logo from 'logo.svg';?

@NShahriNShahriOct 31, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first 3 tests are testing cases when file extension does NOT match to plugin config (.svg in here),
and rest can cover tests when imported file extension matches to config

@NShahriNShahriOct 31, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

svgDefaultImport covers default import of logo.svg

output: 'import logo from "logo";',
},
namedImport: {
code: 'import { logo } from "logo";',
output: 'import { logo } from "logo";',
},
namedImportRenamed: {
code: 'import { Url as logo1 } from "logo";',
output: 'import { Url as logo1 } from "logo";',
},
svgDefaultImport: {
code: 'import logo from "logo.svg";',
output: 'import logo from "logo.svg";',
},
svgNamedImport: {
code: 'import { logo } from "logo.svg";',
output: 'import { logo } from "logo.svg";',
},
svgReactComponentNamedImport: {
code: 'import { ReactComponent as logo } from "logo.svg";',
output:
'import { ReactComponent as logo } from "@svgr/webpack?-prettier,-svgo!logo.svg";',
},
svgMultipleImport: {
code:
'import logo, { logoUrl , ReactComponent as Logo } from "logo.svg";',
output:
'import logo from "logo.svg";\n' +
'import { logoUrl } from "logo.svg";\n' +
'import { ReactComponent as Logo } from "@svgr/webpack?-prettier,-svgo!logo.svg";',
},
},
});
7 changes: 7 additions & 0 deletions packages/babel-plugin-named-asset-import/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,5 +13,12 @@
],
"peerDependencies": {
"@babel/core": "^7.1.0"
},
"devDependencies": {
"babel-plugin-tester": "^5.5.1",
"jest": "^23.6.0"
},
"scripts": {
"test": "jest"
}
}
4 changes: 4 additions & 0 deletions tasks/e2e-simple.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -118,6 +118,10 @@ cd packages/react-dev-utils/
yarn test
cd ../..

cd packages/babel-plugin-named-asset-import/

@NShahriNShahriOct 31, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Timer tests run as part of e2e

yarn test
cd ../..

cd packages/confusing-browser-globals/
yarn test
cd ../..
Expand Down