Test local commands

[mxstbr]

Reference #52 (comment), hope this works…

[mxstbr]

Not sure what's happening on Travis, I don't have access to the logs. @gaearon could you check?

[gaearon]

This is because both argv checks assume there is only one argument. So you can't pass both --debug-template and --smoke-test. Replacing the comparisons with indexOf in both places should do the trick.

[mxstbr]

Sorry, where do I pass --debug-template?

[gaearon]

It is being passed from npm start in local package. (I forgot to do this in that PR and did it in follow up commit).

This flag is read in DEV Webpack config. But there is another flag (for smoke test) read in start.js.

The smoke test flag ensures process terminates. (This is why your PR fails. Smoke test flag is tested for exact match with argv but there are two arguments now. indexOf check should fix it.)

[gaearon]

The problem is in the comparison. It compares '--debug-template --smoke-test' === 'smoke-test' and it fails. It should instead use indexOf. Search for process.argv and you'll see where it happens.

[mxstbr]

Ahh, I got what you mean now, thanks. Should be fixed in the last commit, let's see if Travis passes… ✨

[gaearon]

Now that I think of it we probably should search argv array itself. Also need to do it in both places.

[vjeux]

Since it's starting to be complicated parsing of arguments, should probably use minimist: https://github.com/facebookincubator/create-react-app/blob/master/global-cli/index.js#L43

[mxstbr]

Should just be a case of running process.argv.some((item) => item.indexOf('--smoke-test') > -1)), not sure it's worth introducing a dependency for that…

[mxstbr]

both places

Where's the other place?

[gaearon]

https://github.com/facebookincubator/create-react-app/blob/300cdc7d0aadceca96f1897928770efbc1f3f3c4/config/webpack.config.dev.js#L20

[mxstbr]

This took way longer than anticipated, but should finally be done hopefully!

[gaearon]

😄

[mxstbr]

God dammit, merge conflict

[mxstbr]

Merge?!

[vjeux]

You don't need the exit 1. We use set -e which bails on any commands that returns non 0

[gaearon]

I added those in the first place, I didn’t realize that.
@mxstbr You can kill them throughout this script

[mxstbr]

Done!

[gaearon]

Got it, thanks. I’ll rebase this new because there’s another conflict 😄

[mxstbr]

Thanks! Sorry this took that long 🙏

[gaearon]

This is in now:

49e2fb5
9317d10
ce9fdca
c7bc89c