Skip to content

Ignore json files from TypeScript type checking - #5614

Merged
Timer merged 1 commit into
react:masterfrom
brunolemos:fix/typescript-json
Oct 29, 2018
Merged

Ignore json files from TypeScript type checking#5614
Timer merged 1 commit into
react:masterfrom
brunolemos:fix/typescript-json

Conversation

@brunolemos

@brunolemosbrunolemos commented Oct 29, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix#5613

Sound's like another typescript bug. Opened microsoft/TypeScript#28202

@Timer

Timer commented Oct 29, 2018

Copy link
Copy Markdown
Contributor

Do we have an open issue with typescript about this? Can you link it here please?

@brunolemos

brunolemos commented Oct 29, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

microsoft/TypeScript#28202

I was just trying to create a codesandbox before opening an issue on TypeScript but I'm not being able to make tsx work there: https://codesandbox.io/s/xl1y2vjwk4

@Timer

Timer commented Oct 29, 2018

Copy link
Copy Markdown
Contributor

Awesome!

@Timer

Timer commented Oct 29, 2018

Copy link
Copy Markdown
Contributor

I don't think codesandbox has support for TypeScript yet, maybe try just .ts and don't use JSX?

@TimerTimer added this to the 2.1 milestone Oct 29, 2018
@Timer
Timer merged commit feea693 into react:masterOct 29, 2018
@brunolemos

brunolemos commented Oct 29, 2018

Copy link
Copy Markdown
ContributorAuthor

Didn't work, but nevermind, codesandbox wouldn't show this error output anyway because it's from the typescript compiler

@brunolemos

brunolemos commented Oct 29, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

CodeSandbox will deploy a fix tomorrow: codesandbox/codesandbox-client#1239

TypeScript has already fixed and merged after just a few hours: microsoft/TypeScript#28207

The community is so great 💙

@Timer

Timer commented Oct 29, 2018

Copy link
Copy Markdown
Contributor

I guess we should revert this once that's released?

@brunolemos

brunolemos commented Oct 29, 2018

Copy link
Copy Markdown
ContributorAuthor

Not released yet, just merged. Maybe on 3.1.4.

@Timer

Timer commented Oct 29, 2018

Copy link
Copy Markdown
Contributor

We'll keep this behavior until CRA 3.0.

@TimerTimer mentioned this pull request Oct 29, 2018
Closed
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@brunolemos@Timer
Ignore json files from TypeScript type checking (react#5614)
54c107d
Fixreact#5613
@brunolemos

brunolemos commented Oct 30, 2018

Copy link
Copy Markdown
ContributorAuthor

TypeScript 3.1.4 released; I didn't confirm if the fix was included.

nate770 pushed a commit to ONTW/create-react-app that referenced this pull request Oct 30, 2018
@brunolemos@nate770
Ignore json files from TypeScript type checking (react#5614)
cde4e88
Fixreact#5613
@locklockBot locked and limited conversation to collaborators Jan 18, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signedtag: bug fix

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@brunolemos@Timer@facebook-github-bot