Skip to content

Remove unused dependencies in babel-preset-react-app - #5818

Merged
iansu merged 5 commits into
react:masterfrom
iansu:babel-preset-react-app-unused-deps
Aug 9, 2019
Merged

Remove unused dependencies in babel-preset-react-app#5818
iansu merged 5 commits into
react:masterfrom
iansu:babel-preset-react-app-unused-deps

Conversation

@iansu

@iansuiansu commented Nov 15, 2018

Copy link
Copy Markdown
Contributor

Closes#5165

Timer
Timer approved these changes Nov 15, 2018
View reviewed changes

@TimerTimer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@TimerTimer added this to the 2.1.2 milestone Nov 15, 2018
@iansu

iansu commented Nov 15, 2018

Copy link
Copy Markdown
ContributorAuthor

That's my plan for checking if they're really unused. 😀

@iansu

iansu commented Nov 15, 2018

Copy link
Copy Markdown
ContributorAuthor

It looks like SVGR might need some of these. Let's try this again after we upgrade to SVGR 4: #5816

@TimerTimer modified the milestones: 2.1.2, 2.1.3Dec 23, 2018
@ianschmitzianschmitz modified the milestones: 2.1.3, 2.1.4Jan 4, 2019
@ianschmitz

ianschmitz commented Jan 6, 2019

Copy link
Copy Markdown
Contributor

Related: #6124

@ianschmitzianschmitz modified the milestones: 2.1.4, 2.1.5Feb 10, 2019
@iansuiansu modified the milestones: 2.1.6, 2.1.x, 3.xMar 6, 2019
@ianschmitzianschmitz modified the milestones: 3.x, 3.1Aug 4, 2019
@ianschmitz

ianschmitz commented Aug 6, 2019

Copy link
Copy Markdown
Contributor

Seems some of these are still required?

./src/index.tsx | Error: [BABEL] /home/vsts/work/_temp/tmp.AAcKXmwFdW/test-app-typescript/src/index.tsx: Cannot find module '@babel/plugin-transform-react-display-name' (While processing: "/home/vsts/work/_temp/tmp.AAcKXmwFdW/test-app-typescript/node_modules/babel-preset-react-app/index.js$1")

@iansu

iansu commented Aug 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Well, CI passed. How confident are we in our tests? 😀

@iansu
iansu merged commit f09d3d3 into react:masterAug 9, 2019
@iansu
iansu deleted the babel-preset-react-app-unused-deps branch August 9, 2019 20:04
@iansu

iansu commented Aug 9, 2019

Copy link
Copy Markdown
ContributorAuthor

YOLO

@locklockBot locked and limited conversation to collaborators Aug 14, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bugzpodderbugzpodderAwaiting requested review from bugzpodder
@ianschmitzianschmitzAwaiting requested review from ianschmitz
@mrmckebmrmckebAwaiting requested review from mrmckeb
@petetntpetetntAwaiting requested review from petetnt
1 more reviewer
@TimerTimerTimer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: internal

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

Unused depedencies in babel-preset-react-app?

4 participants

@iansu@ianschmitz@Timer@facebook-github-bot