Skip to content

Include absoluteRuntime in babel preset docs - #5847

Merged
ianschmitz merged 3 commits into
react:masterfrom
iddan:master
Apr 4, 2020
Merged

Include absoluteRuntime in babel preset docs#5847
ianschmitz merged 3 commits into
react:masterfrom
iddan:master

Conversation

@iddan

@iddaniddan commented Nov 17, 2018

Copy link
Copy Markdown
Contributor

Documented babel-preset-react-app absoluteRuntime option

@iddan
Babel preset absoluteRuntime docs
b809b36
Documented babel-preset-react-app absoluteRuntime option
@iddaniddan mentioned this pull request Nov 17, 2018
Closed
@TimerTimer added this to the 2.1.x milestone Nov 18, 2018
@mrmckebmrmckeb self-assigned this Dec 9, 2018
@mrmckeb

mrmckeb commented Dec 9, 2018

Copy link
Copy Markdown
Contributor

Thanks for this @iddan. Out of interest, what was the motivation for this PR? Was it an issue you faced yourself? And if so, why did you need to modify this setting?

Thanks!

@iddan

iddan commented Dec 9, 2018

Copy link
Copy Markdown
ContributorAuthor

If I remember correctly I stumbled upon it while trying to integrate Storybook

mrmckeb
mrmckeb suggested changes Dec 9, 2018
View reviewed changes

@mrmckebmrmckeb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iddan, two comments here - but looks good.

By the way, Storybook now works with create-react-app (including TypeScript and CSS modules (Sass included) without a custom config.

Comment threadpackages/babel-preset-react-app/README.md Outdated
Comment threadpackages/babel-preset-react-app/README.md
@thallada

thallada commented Dec 31, 2018

Copy link
Copy Markdown

I think this should be merged! It turns out that this plugin was causing the contenthash for my JS bundles to change when building the exact same code between two different directories. And I didn't know about it because minification was stripping out the absolute paths from the final bundle. I'm not sure why absoluteRuntime needs to be true anyways, perhaps it should default to false instead?

See: webpack/webpack#1155 and webpack/webpack#7179

@iansuiansu modified the milestones: 2.1.x, 3.xMar 10, 2019
@iddan@mrmckeb
Update packages/babel-preset-react-app/README.md
8b70df8
Co-Authored-By: Brody McKee <mrmckeb@users.noreply.github.com>
@iddan

iddan commented Apr 1, 2020

Copy link
Copy Markdown
ContributorAuthor

Why was this not merged?

@ianschmitzianschmitz modified the milestones: 3.x, 3.4.2Apr 4, 2020
@ianschmitz
ianschmitz requested a review from mrmckebApril 4, 2020 23:31
@ianschmitzianschmitz changed the title Babel preset absoluteRuntime docsInclude absoluteRuntime in babel preset docsApr 4, 2020
@ianschmitz
ianschmitz merged commit c7352c7 into react:masterApr 4, 2020
@ianschmitz

ianschmitz commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

Sorry this got missed. Thanks @iddan.

@locklockBot locked and limited conversation to collaborators Apr 15, 2020
@ianschmitzianschmitz modified the milestones: 3.5, 4.0May 3, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ianschmitzianschmitzAwaiting requested review from ianschmitz
@iansuiansuAwaiting requested review from iansu
@petetntpetetntAwaiting requested review from petetnt
@mrmckebmrmckebAwaiting requested review from mrmckeb

Assignees

@mrmckebmrmckeb

Labels

CLA Signedtag: documentation

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

7 participants

@iddan@mrmckeb@thallada@ianschmitz@iansu@Timer@facebook-github-bot