Skip to content

Update links to docs in all package README files - #5912

Merged
iansu merged 3 commits into
react:masterfrom
iansu:update-readme-doc-links
Dec 6, 2018
Merged

Update links to docs in all package README files#5912
iansu merged 3 commits into
react:masterfrom
iansu:update-readme-doc-links

Conversation

@iansu

Copy link
Copy Markdown
Contributor

There are also a lot of links to the old README in the CHANGELOGs but I don't know if we want to update those.

@iansu

Copy link
Copy Markdown
ContributorAuthor

Somehow these changes are breaking the behaviour test suite. 😂

@Timer Any idea why this might be happening? It must have something to do with the change to packages/react-scripts/bin/react-scripts.js.

@deftomat

deftomat commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

AppVeyor failed due to 60 minutes limit. The same happened to PR #5903.

There is probably a limit for open-source projects.

@netlify

netlifyBot commented Dec 6, 2018

Copy link
Copy Markdown

Deploy preview for create-react-app ready!

Built with commit 49b41a6

https://deploy-preview-5912--create-react-app.netlify.com

@iansu
iansuforce-pushed the update-readme-doc-links branch from 9ccef3d to 49b41a6CompareDecember 6, 2018 20:09
@iansuiansu added this to the 2.1.2 milestone Dec 6, 2018
@iansu
iansu merged commit 7513481 into react:masterDec 6, 2018
timsnadden added a commit to timsnadden/create-react-app that referenced this pull request Dec 7, 2018
* master: (39 commits)
Added extension to .eslintrc (react#5988)
Update links to docs in all package README files (react#5912)
Use https for linked images in docs to fix mixed content warnings (react#5985)
Improve error messaging in verifyPackageTree.js (react#5974)
Add removeItem to localStorage mock in docs (react#5919)
Add SASS_PATH instructions to Sass docs (react#5917)
Suggest a different default for speed reasons (react#5959)
Add pre-eject message about new features in v2 (react#5954)
Add netlify.toml to prepare for deploy to netlify react#5807 (react#5930)
Correct some comments (react#5927)
Add note to docs about using Sass and Flow together (react#5823)
Update PWA link in README (react#5907)
Add placeholders to template README for bit.ly links. (react#5808)
Disable copy to clipboard in cra --info (react#5905)
Support setupTests.ts (react#5698)
Remove unnecessary whitespace in template HTML
Run prettier on HTML files (react#5839)
Some Grammar fixes (react#5858)
Fix link to page about running tests (react#5883)
fix: make typescriptformatter support 0.5 of fork checker (react#5879)
...
@locklockBot locked and limited conversation to collaborators Jan 18, 2019
@iansu
iansu deleted the update-readme-doc-links branch October 17, 2019 23:33
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@iansu@deftomat@facebook-github-bot