Skip to content

[WIP] Hot reloading (only for Hooks) - #5958

Open
gaearon wants to merge 47 commits into
react:mainfrom
gaearon:hot-reload-again
Open

[WIP] Hot reloading (only for Hooks)#5958
gaearon wants to merge 47 commits into
react:mainfrom
gaearon:hot-reload-again

Conversation

@gaearon

@gaearongaearon commented Dec 3, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

I don't know if this is going to work but I'm going to try another time. Hooks were another piece of the puzzle. Maybe it'll work out.

Preserving state is Hooks-only. It's too brittle for classes. With Hooks it "just works" by design.

@gaearongaearon changed the title [WIP] Hot reloading[WIP] Hot reloading (only for Hooks)Dec 3, 2018
@netlify

netlifyBot commented Dec 3, 2018•
edited
Loading

Copy link
Copy Markdown

Deploy preview for create-react-app ready!

Built with commit 43e5f2e

https://deploy-preview-5958--create-react-app.netlify.com

@gaearon
gaearonforce-pushed the hot-reload-again branch 2 times, most recently from 7066e8a to 543ff93CompareDecember 4, 2018 10:25
@stale

staleBot commented Jan 12, 2019

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Jan 12, 2019
@stale

staleBot commented Feb 11, 2019

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Feb 11, 2019
@gausie

gausie commented Feb 11, 2019

Copy link
Copy Markdown

Please bot do not stale 🙏🤖

@stalestaleBot removed the stale label Feb 11, 2019
@stale

staleBot commented Mar 13, 2019

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Mar 13, 2019
@stalestaleBot removed the stale label Mar 13, 2019
@iansuiansu added this to the 100.0.0 milestone Mar 14, 2019
@bugzpodderbugzpodder mentioned this pull request Jul 5, 2019
Closed
@mrmckebmrmckeb mentioned this pull request Jul 24, 2019
Closed
8 tasks
@devlocodevloco mentioned this pull request Aug 14, 2019
Closed
@bvaughnbvaughn mentioned this pull request Aug 29, 2019
Closed
@IronSean

IronSean commented Oct 11, 2019

Copy link
Copy Markdown

Where is this at? What can be done to help?

@bjunix

bjunix commented Jan 17, 2020•
edited
Loading

Copy link
Copy Markdown

Where is this at? What can be done to help?

Looks like the discussion is moved here: react/react#16604 (comment)

@mihanizm56

mihanizm56 commented May 24, 2020•
edited
Loading

Copy link
Copy Markdown

A lot of apps are written with classes.
This is a breaking change for them =(((
Why not to do it for class-components ??

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signedtag: new feature

Projects

None yet

Milestone

100.0

Development

Successfully merging this pull request may close these issues.

9 participants

@gaearon@gausie@IronSean@bjunix@mihanizm56@iansu@ianschmitz@facebook-github-bot@Timer