Skip to content

Add deployment instructions with AWS Amplify - #6208

Merged
iansu merged 7 commits into
react:masterfrom
swaminator:master
Mar 21, 2019
Merged

Add deployment instructions with AWS Amplify#6208
iansu merged 7 commits into
react:masterfrom
swaminator:master

Conversation

@swaminator

@swaminatorswaminator commented Jan 15, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Added instructions on how to deploy a CRA app with AWS Amplify.

@facebook-github-bot

facebook-github-bot commented Jan 15, 2019

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Jan 24, 2019

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@swaminator

swaminator commented Jan 24, 2019

Copy link
Copy Markdown
ContributorAuthor

Hi - now that the CLA has been signed, would appreciate feedback on this PR. Thanks!

@swaminator

swaminator commented Jan 29, 2019

Copy link
Copy Markdown
ContributorAuthor

@npverni@saimonmoore Please review this PR and let me know if it can be merged. Thanks!

@swaminator

swaminator commented Feb 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Following up again with more folks @mg. Can we please review this PR? Thanks.

@mg

mg commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

I don't understand why I am being included in this, surely you mean to tag someone else?

@swaminator

swaminator commented Feb 2, 2019

Copy link
Copy Markdown
ContributorAuthor

Apologies for the tag (you showed up when I typed out the message in the editor box). I'm looking for someone to review my PR so it can get merged. Haven't had too much luck getting anyone to respond in the past week.

@stale

staleBot commented Mar 4, 2019

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Mar 4, 2019
@iansuiansu removed the stale label Mar 4, 2019
@iansuiansu self-assigned this Mar 4, 2019
@iansu
iansu requested a review from amyrlamMarch 4, 2019 06:12
@swaminator

swaminator commented Mar 8, 2019

Copy link
Copy Markdown
ContributorAuthor

Hi @iansu, I'd love for this PR to be reviewed and accepted.

@swaminator

swaminator commented Mar 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@amyrlam Can you please review this PR? It's been 2 months.

iansu
iansu suggested changes Mar 19, 2019
View reviewed changes
Comment threaddocusaurus/docs/deployment.md Outdated
Comment threaddocusaurus/docs/deployment.md Outdated
Comment threaddocusaurus/docs/deployment.md Outdated
iansuand others added 3 commits March 20, 2019 16:47
@iansu@swaminator
Update docusaurus/docs/deployment.md
0526a2f
create-react-app to Create React App
Co-Authored-By: swaminator <nikhil@live.ca>
@iansu@swaminator
Update docusaurus/docs/deployment.md
8b68e76
Removed extra verbiage.
Co-Authored-By: swaminator <nikhil@live.ca>
@swaminator
Removed GIF
27ff346
@swaminator

swaminator commented Mar 20, 2019

Copy link
Copy Markdown
ContributorAuthor

@iansu all requested changes are made.

@iansuiansu added this to the 3.0 milestone Mar 21, 2019
@iansu
iansu merged commit 5c637a4 into react:masterMar 21, 2019
@iansu

iansu commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Looks good. Thanks!

@swaminator

swaminator commented Mar 21, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks @iansu. I just visited the webpage and don't see the docs yet. Is there a delay for propagation?

@iansu

iansu commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Yes, we generally only publish the docs after each release.

@locklockBot locked and limited conversation to collaborators Mar 26, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amyrlamamyrlamAwaiting requested review from amyrlam
1 more reviewer
@iansuiansuiansu requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@iansuiansu

Labels

CLA Signedtag: documentation

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@swaminator@facebook-github-bot@mg@iansu