Skip to content

Only use yarn.lock.cached if using the default Yarn registry - #6253

Merged
gaearon merged 1 commit into
react:masterfrom
meo8:yarn-lock-cached
Feb 18, 2019
Merged

Only use yarn.lock.cached if using the default Yarn registry#6253
gaearon merged 1 commit into
react:masterfrom
meo8:yarn-lock-cached

Conversation

@meo8

@meo8meo8 commented Jan 23, 2019

Copy link
Copy Markdown

This PR supersedes #5745 and correctly implements @NMinhNguyen's requested changes.

@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Comment threadpackages/create-react-app/createReactApp.js Outdated
@gaearon
gaearon merged commit a8af55d into react:masterFeb 18, 2019
@gaearon

Copy link
Copy Markdown
Contributor

Looks good, thanks.

@ianschmitzianschmitz added this to the 2.1.6 milestone Feb 18, 2019
@locklockBot locked and limited conversation to collaborators Feb 23, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@meo8@facebook-github-bot@gaearon@NMinhNguyen@ianschmitz