Uh oh!
There was an error while loading. Please reload this page.
Remove body padding reset from templates - #6300
Merged
Merged
Conversation
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Hurtak
requested review from
Timer, amyrlam, bugzpodder, gaearon, ianschmitz, iansu, mrmckeb and petetnt
as code ownersFebruary 28, 2019 14:50
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Hurtak
commented
Apr 24, 2019
ContributorAuthor
Ping |
mrmckeb
commented
Apr 24, 2019
Contributor
Hi @Hurtak, you're correct and I've confirmed with some independent research. I've also noted that this is not included in |
mrmckeb
approved these changes
Apr 24, 2019
ianschmitz
approved these changes
Apr 24, 2019
iansu
commented
Apr 24, 2019
Contributor
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAIK reseting padding is useless since there is no padding on body in browser default styles
https://www.w3schools.com/cssref/css_default_values.asp