Skip to content

Update webpack-dev-server to 3.2.1 - #6483

Merged
ianschmitz merged 2 commits into
react:masterfrom
ThePrez:patch-1
Mar 9, 2019
Merged

Update webpack-dev-server to 3.2.1#6483
ianschmitz merged 2 commits into
react:masterfrom
ThePrez:patch-1

Conversation

@ThePrez

Copy link
Copy Markdown
Contributor

This PR is a simple request to upgrade the version of webpack-dev-server, which adds support for the IBM i platform and AIX.

Currently, the install of react-scripts fails because of an old version of internal-ip that was not installable on these platforms. webpack-dev-server was updated in this PR: webpack/webpack-dev-server#1668 which landed in 3.2.0

@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz

Copy link
Copy Markdown
Contributor

It sounds like we'll want to wait for webpack/webpack-dev-server#1676 to be released and upgrade when that fix is in.

@ThePrez

Copy link
Copy Markdown
ContributorAuthor

@ianschmitz, I agree with that assessment. Thanks!

@alexandrahrastnik

Copy link
Copy Markdown

Same as #6478

@ThePrez

Copy link
Copy Markdown
ContributorAuthor

Closing this PR for now due to issues in the default-gateway changes with npm ci
silverwind/default-gateway#5
silverwind/default-gateway#10
Let's wait for that to be sorted out also.

@ThePrezThePrez closed this Feb 22, 2019
@ThePrezThePrez changed the title Update webpack-dev-server to 3.2.0Update webpack-dev-server to 3.2.1Feb 25, 2019
@ThePrezThePrez reopened this Feb 25, 2019
@ThePrez

Copy link
Copy Markdown
ContributorAuthor

Reopening now that webpack/webpack-dev-server#1676 has landed in version 3.2.1

@ianschmitzianschmitz added this to the 2.1.6 milestone Feb 26, 2019
@iansuiansu modified the milestones: 2.1.6, 2.1.xMar 6, 2019
@ianschmitzianschmitz modified the milestones: 2.1.x, 2.1.9Mar 9, 2019
@ianschmitz
ianschmitz merged commit c54e36d into react:masterMar 9, 2019
@ianschmitz

Copy link
Copy Markdown
Contributor

Thanks!

@iansuiansu modified the milestones: 2.1.9, 3.0Mar 10, 2019
JoviDeCroock added a commit to JoviDeCroock/create-react-app that referenced this pull request Mar 15, 2019
* masterd: (24 commits)
Add TypeScript linting support (react#6513)
Support React Hooks (react#5602) (react#5997)
Support browserslist in @babel/preset-env (react#6608)
Add empty mock for http2 (react#5686)
Add note about npx caching (react#6374)
change named import into default import (react#6625)
Stage files for commit after ejecting (react#5960)
Upgrade dependencies (react#6614)
Make compiler variable const instead of let (react#6621)
Type check JSON files (react#6615)
Change class components to functional components in templates (react#6451)
Convert JSON.stringify \n to os.EOL when writing tsconfig.json (react#6610)
Update html-webpack-plugin (react#6361)
Enable click to go to error in console for TypeScript (react#6502)
Update webpack-dev-server to 3.2.1 (react#6483)
[docs] revert removal of newlines from html (react#6386)
Publish
Prepare 2.1.8 release
Reapply "Speed up TypeScript v2 (react#6406)" (react#6586)
Publish
...
# Conflicts:
#	packages/babel-preset-react-app/create.js
#	packages/react-scripts/scripts/build.js
@locklockBot locked and limited conversation to collaborators Mar 15, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ThePrez@facebook-github-bot@ianschmitz@alexandrahrastnik@iansu