Skip to content

Add audio support in url loader - #665

Merged
gaearon merged 1 commit into
react:masterfrom
danharper:audio
Sep 17, 2016
Merged

Add audio support in url loader#665
gaearon merged 1 commit into
react:masterfrom
danharper:audio

Conversation

@danharper

Copy link
Copy Markdown
Contributor

No description provided.

@ghostghost added the CLA Signed label Sep 17, 2016
@gaearon

Copy link
Copy Markdown
Contributor

Can you also send a PR to https://github.com/scottcorgan/pushstate-server to support them please?
Just like scottcorgan/pushstate-server#21.

@gaearongaearon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a PR to pushstate-server.

@danharper

Copy link
Copy Markdown
ContributorAuthor

Sure - on it now.

@danharper

danharper commented Sep 17, 2016

Copy link
Copy Markdown
ContributorAuthor

Looks like that project's recently released a new version which doesn't require any file extension whitelist - it just serves everything. Do you know what version of it is used? (can't find it in the package.json)

@gaearon

Copy link
Copy Markdown
Contributor

Haha, that’s cool.
We don’t explicitly depend on it, just include it in “how to serve build folder” instructions.
So it looks good then.

@gaearongaearon added this to the 0.4.2 milestone Sep 17, 2016
@gaearon
gaearon merged commit a5bf074 into react:masterSep 17, 2016
This was referenced Sep 17, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@locklockBot locked and limited conversation to collaborators Jan 22, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danharper@gaearon