Skip to content

Kill verdaccio in CI tasks cleanup - #6700

Merged
ianschmitz merged 1 commit into
react:masterfrom
santoshyadavdev:bug--Kill-verdaccio-in-CI-tasks-cleanup
Mar 26, 2019
Merged

Kill verdaccio in CI tasks cleanup#6700
ianschmitz merged 1 commit into
react:masterfrom
santoshyadavdev:bug--Kill-verdaccio-in-CI-tasks-cleanup

Conversation

@santoshyadavdev

@santoshyadavdevsantoshyadavdev commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Fixes#6663.

@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitzianschmitz changed the title bug: Kill verdaccio in CI tasks cleanupKill verdaccio in CI tasks cleanupMar 22, 2019
@ianschmitz

Copy link
Copy Markdown
Contributor

Looks like that worked!

https://travis-ci.org/facebook/create-react-app/jobs/509467770#L1827

Can you update our other e2e scripts that use verdaccio with the same cleanup logic?

@ianschmitzianschmitz self-assigned this Mar 22, 2019
@santoshyadavdev

Copy link
Copy Markdown
ContributorAuthor

Looks like that worked!

https://travis-ci.org/facebook/create-react-app/jobs/509467770#L1827

Can you update our other e2e scripts that use verdaccio with the same cleanup logic?

Done, waiting for build.

@santoshyadavdev

Copy link
Copy Markdown
ContributorAuthor

@ianschmitz ,
The changes worked for other task as well. Let me know if we need any other changes.

Comment threadtasks/e2e-old-node.sh Outdated
@santoshyadavdev

Copy link
Copy Markdown
ContributorAuthor

Hi @ianschmitz ,

Let me know if any changes are needed.

@ianschmitzianschmitz added this to the 3.0 milestone Mar 26, 2019
@ianschmitz
ianschmitz merged commit 5acb286 into react:masterMar 26, 2019
@ianschmitz

Copy link
Copy Markdown
Contributor

Looks good. Thanks @santoshyadav198613

@locklockBot locked and limited conversation to collaborators Mar 31, 2019
@santoshyadavdev
santoshyadavdev deleted the bug--Kill-verdaccio-in-CI-tasks-cleanup branch October 19, 2021 11:37
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@santoshyadavdev@facebook-github-bot@ianschmitz