Uh oh!
There was an error while loading. Please reload this page.
Kill verdaccio in CI tasks cleanup - #6700
Conversation
facebook-github-bot
commented
Mar 21, 2019
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Mar 21, 2019
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ianschmitz
commented
Mar 22, 2019
Looks like that worked! https://travis-ci.org/facebook/create-react-app/jobs/509467770#L1827 Can you update our other e2e scripts that use verdaccio with the same cleanup logic? |
santoshyadavdev
commented
Mar 22, 2019
Done, waiting for build. |
santoshyadavdev
commented
Mar 22, 2019
@ianschmitz , |
Uh oh!
There was an error while loading. Please reload this page.
santoshyadavdev
commented
Mar 25, 2019
Hi @ianschmitz , Let me know if any changes are needed. |
ianschmitz
commented
Mar 26, 2019
Looks good. Thanks @santoshyadav198613 |
Fixes#6663.