Uh oh!
There was an error while loading. Please reload this page.
fix: terser-webpack-plugin hanging on WSL - #6732
Merged
Merged
Conversation
endiliey
requested review from
Timer, amyrlam, bugzpodder, gaearon, ianschmitz, iansu, mrmckeb and petetnt
as code ownersMarch 31, 2019 06:22
iansu
commented
Apr 4, 2019
Contributor
Please resolve merge conflicts. |
endiliey
commented
Apr 5, 2019
ContributorAuthor
@iansu seems that a kind hearted @bugzpodder has done that. Thank you 👍 |
iansu
commented
Apr 5, 2019
Contributor
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix#6723
When running
react-scripts buildon Windows Subsystem for Linux, the webpack build will hang during the uglifying step. This is caused due to a bug on terser not being able to run in parallel on WSL(webpack/minimizer-webpack-plugin#21)
This PR attempts to disable parallel run on WSL until that bug is fixed upstream