Skip to content

Add test for special scripts versions - #681

Merged
gaearon merged 1 commit into
react:masterfrom
yesmeck:master
Sep 19, 2016
Merged

Add test for special scripts versions#681
gaearon merged 1 commit into
react:masterfrom
yesmeck:master

Conversation

@yesmeck

@yesmeckyesmeck commented Sep 19, 2016

Copy link
Copy Markdown
Contributor

I published a react-scripts-fork package to npm for testing.

@ghostghost added the CLA Signed label Sep 19, 2016
Comment threadtasks/e2e.sh Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should at least test something. Perhaps that the created project contains the corresponding fork in node_modules.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some asserts.

@ghostghost added the CLA Signed label Sep 19, 2016
@gaearon
gaearon merged commit 36d6868 into react:masterSep 19, 2016
@gaearon

Copy link
Copy Markdown
Contributor

Yay. Thank you so much!

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@locklockBot locked and limited conversation to collaborators Jan 22, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@yesmeck@gaearon