Uh oh!
There was an error while loading. Please reload this page.
Change cssmodule classname hash to use repo relative paths instead of… - #6876
Conversation
… system absolute paths
facebook-github-bot
commented
Apr 23, 2019
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Uh oh!
There was an error while loading. Please reload this page.
project relative paths used in css module hashing
facebook-github-bot
commented
Apr 27, 2019
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ianschmitz
commented
Apr 28, 2019
Thanks. Great first contribution! |
Fixes#6875.
I tested this using two clones of a project using CRA and css modules. The clones have different paths. Before this PR, the classname hashes would be different, after the change the classnames are the same.