Skip to content

Configurable eslint-loader - #6973

Closed
caub wants to merge 2 commits into
react:masterfrom
caub:eslint
Closed

Configurable eslint-loader#6973
caub wants to merge 2 commits into
react:masterfrom
caub:eslint

Conversation

@caub

@caubcaub commented May 3, 2019

Copy link
Copy Markdown

This a very simple, and backward compatible PR to allow to a custom .eslintrc to be used

Comment threadpackages/react-scripts/scripts/start.js Outdated

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configurable quiet as well, for example when upgrading an old project, you can have thousands of warnings temporarily

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RS_ESLINTRC is the main point of this PR, when this env var is defined, baseConfig is not used, and a local .eslintrc is used

Comment threadpackages/react-scripts/scripts/start.js Outdated
@FezVrasta

Copy link
Copy Markdown
Contributor

What's the point of adding this behind a env variable? Couldn't we simply detect the existence of an eslintrc file and automatically enable it?

@ianschmitz

Copy link
Copy Markdown
Contributor

Before merging something like this in we will have to look into what options we have for extending our typescript-eslint config.

/cc @mrmckeb

Comment thread.gitignore Outdated
@caub

caub commented May 19, 2019

Copy link
Copy Markdown
Author

@FezVrasta I first tried to keep backward compatibility, but your idea looks better, I pushed a commit for this

Comment threadpackages/react-scripts/config/webpack.config.js Outdated
@mrmckeb

Copy link
Copy Markdown
Contributor

Hi @caub, we've been discussing this PR - do you think it would cover most of your needs?
#7036

@caub

caub commented May 21, 2019

Copy link
Copy Markdown
Author

@mrmckeb Thanks, yes it does

@mrmckeb

Copy link
Copy Markdown
Contributor

I'm closing this off for now in favour of the PR discussed, and am definitely open to extending that to support more ESLint formats in the near future.

Thanks for your work here.

@mrmckebmrmckeb closed this May 23, 2019
@locklockBot locked and limited conversation to collaborators May 30, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@caub@FezVrasta@ianschmitz@mrmckeb@Asday@Timer@facebook-github-bot