Uh oh!
There was an error while loading. Please reload this page.
Configurable eslint-loader - #6973
Conversation
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
configurable quiet as well, for example when upgrading an old project, you can have thousands of warnings temporarily
There was a problem hiding this comment.
RS_ESLINTRC is the main point of this PR, when this env var is defined, baseConfig is not used, and a local .eslintrc is used
Uh oh!
There was an error while loading. Please reload this page.
FezVrasta
commented
May 3, 2019
What's the point of adding this behind a env variable? Couldn't we simply detect the existence of an eslintrc file and automatically enable it? |
ianschmitz
commented
May 3, 2019
Before merging something like this in we will have to look into what options we have for extending our /cc @mrmckeb |
Uh oh!
There was an error while loading. Please reload this page.
@FezVrasta I first tried to keep backward compatibility, but your idea looks better, I pushed a commit for this |
Uh oh!
There was an error while loading. Please reload this page.
mrmckeb
commented
May 21, 2019
caub
commented
May 21, 2019
@mrmckeb Thanks, yes it does |
mrmckeb
commented
May 23, 2019
I'm closing this off for now in favour of the PR discussed, and am definitely open to extending that to support more ESLint formats in the near future. Thanks for your work here. |
This a very simple, and backward compatible PR to allow to a custom .eslintrc to be used