Skip to content

openBrowser() causes docker-compose set ups to fail because of spawn EACCESS - #711

Merged
gaearon merged 2 commits into
react:masterfrom
aeneasr:patch-1
Sep 23, 2016
Merged

openBrowser() causes docker-compose set ups to fail because of spawn EACCESS #711
gaearon merged 2 commits into
react:masterfrom
aeneasr:patch-1

Conversation

@aeneasr

@aeneasraeneasr commented Sep 23, 2016

Copy link
Copy Markdown

closes#710

@ghost

ghost commented Sep 23, 2016

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@arekkasAeneas Rekkas (arekkas)
openBrowser() causes docker-compose set ups to fail because of spawn …
6e4e0ae
…EACCESS - closesreact#710
Signed-off-by: Aeneas Rekkas (arekkas) <aeneas@ory.am>
@ghostghost added the CLA Signed label Sep 23, 2016
@ghost

ghost commented Sep 23, 2016

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearongaearon added this to the 0.5.0 milestone Sep 23, 2016
@gaearon
gaearon merged commit 2050174 into react:masterSep 23, 2016
@gaearon

gaearon commented Sep 23, 2016

Copy link
Copy Markdown
Contributor

Thanks!

@aeneasr

aeneasr commented Sep 23, 2016

Copy link
Copy Markdown
Author

Awesome, thanks for merging @gaearon !

@aeneasr
aeneasr deleted the patch-1 branch September 23, 2016 10:34
@aeneasr

aeneasr commented Sep 23, 2016

Copy link
Copy Markdown
Author

@gaearon any chance this could make it in the 0.4.4 release as it's only a bug fix with no bc or other side effects?

@gaearon

gaearon commented Sep 23, 2016

Copy link
Copy Markdown
Contributor

I plan to release 0.5.0 today. I likely won't have the time to do two releases today so I hope it won't be too much of an inconvenience to you.

@aeneasr

aeneasr commented Sep 23, 2016

Copy link
Copy Markdown
Author

Ah awesome! I thought the 0.5.0 release would be some way further down the road because I saw 0.4.3 and 0.4.4 lined up. That will be aboslutely fast enough :)

Thanks for the uber quick responses!

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@arekkas@feiqitian
openBrowser() causes docker-compose set ups to fail because of spawn …
177b5ec
…EACCESS (react#711)
* openBrowser() causes docker-compose set ups to fail because of spawn EACCESS - closesreact#710
Signed-off-by: Aeneas Rekkas (arekkas) <aeneas@ory.am>
* Ignore errors
@locklockBot locked and limited conversation to collaborators Jan 22, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

openBrowser() causes docker-compose set ups to fail because of spawn EACCESS

3 participants

@aeneasr@gaearon@arekkas