Fix RegExp from navigateFallbackBlacklist (workbox)

[nuragic]

Hello,

This lovely RegExp was preventing my index.html to be served from ServiceWorker after an authentication callback; the request always hit the network…

Here is an example of this kind of "auth requests" callback:

https://example.com/PWA/callback?code=a55b99fbe42a3a7663b344020d2407047f4eb206aded15c300568ca4ef1219ce&scope=openid%20profile%20organizations%20api1%20offline_access&state=12c7c99a9b75476545161b45302e2cd&session_state=_p1MWLryvh08qxT-gmvucCIFVsWh8rIwo_MUBjhjvyY.5f6ee222da987db8c21aa4a35f93ada

The problem was that it was blacklisted by workbox because… it contains a . ! 😟

I believe it would be just safer to remove it… I hope this will prevent fellow devs opting in for SW wasting a lot of time like I did to found out! 😅

Thanks!

[Timer]

cc @jeffposnick

[jeffposnick]

I did some digging into the history to refresh my memory. Here's the underlying issue that led to that configuration being used: #3008

Given that there's no easy way to enable/disable/override the default Workbox configuration options, I'd imagine that the conclusion about the most reasonable sett of defaults expressed in #3008 still apply, and just dropping the RegExp entirely is likely to cause issues.

If a modification to the RegExp so that it only matched on . characters before, rather than after, a ? character is sufficient, then that seems like a good compromise.

[nuragic]

If a modification to the RegExp so that it only matched on . characters before, rather than after, a ? character is sufficient, then that seems like a good compromise.

Gotcha! I will just modify the regexp then. Thanks for the additional context.

[nuragic]

Fixed. Let me know if you have any additional concerns.

[jeffposnick]

👍 from my point of view.

[nuragic]

Cool, many thanks for the review!

[nuragic]

👀 👋 I guess it's safe to merge?

[iansu]

Thanks!

[nuragic]

Cool thank you!