Skip to content

jsx-no-duplicate-props ignore case fix - #7230

Merged
ianschmitz merged 4 commits into
react:masterfrom
rommguy:eslint-ignore-case-fix
Jul 16, 2019
Merged

jsx-no-duplicate-props ignore case fix#7230
ianschmitz merged 4 commits into
react:masterfrom
rommguy:eslint-ignore-case-fix

Conversation

@rommguy

@rommguyrommguy commented Jun 16, 2019•
edited by ianschmitz
Loading

Copy link
Copy Markdown
Contributor

Fixes#6956.

@facebook-github-bot

facebook-github-bot commented Jun 16, 2019

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@rommguyrommguy mentioned this pull request Jun 16, 2019
Closed
@rommguy

rommguy commented Jun 16, 2019

Copy link
Copy Markdown
ContributorAuthor

This PR fixes #6956

@facebook-github-bot

facebook-github-bot commented Jun 16, 2019

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

ianschmitz
ianschmitz reviewed Jun 17, 2019
View reviewed changes
Comment threadpackages/eslint-config-react-app/index.js Outdated
@rommguy@ianschmitz
Update packages/eslint-config-react-app/index.js
ae5840a
Co-Authored-By: Ian Schmitz <ianschmitz@gmail.com>
@ianschmitzianschmitz added this to the 3.0.2 milestone Jun 18, 2019
@rommguy

rommguy commented Jul 9, 2019

Copy link
Copy Markdown
ContributorAuthor

@ianschmitz Any chance this will be merged soon?

@ianschmitzianschmitz changed the title Eslint ignore case fixjsx-no-duplicate-props ignore case fixJul 16, 2019
@ianschmitz
ianschmitz merged commit 2d57fa3 into react:masterJul 16, 2019
@rommguy

rommguy commented Jul 16, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks @ianschmitz

@rommguy
rommguy deleted the eslint-ignore-case-fix branch July 16, 2019 18:08
@locklockBot locked and limited conversation to collaborators Jul 21, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amyrlamamyrlamAwaiting requested review from amyrlam
@gaearongaearonAwaiting requested review from gaearon
@iansuiansuAwaiting requested review from iansu
@mrmckebmrmckebAwaiting requested review from mrmckeb
@petetntpetetntAwaiting requested review from petetnt
@TimerTimerAwaiting requested review from Timer
2 more reviewers
@ianschmitzianschmitzianschmitz approved these changes
@bugzpodderbugzpodderbugzpodder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: bug fix

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

Why ignoring casing on jsx-no-duplicate-props?

4 participants

@rommguy@facebook-github-bot@ianschmitz@bugzpodder