Skip to content

Respect app's eslintrc - #7369

Closed
chyipin wants to merge 1 commit into
react:masterfrom
chyipin:support-app-eslintrc
Closed

Respect app's eslintrc#7369
chyipin wants to merge 1 commit into
react:masterfrom
chyipin:support-app-eslintrc

Conversation

@chyipin

Copy link
Copy Markdown
Contributor

Allow react app to configure eslint without resorting to eject

Test Instructions

  1. npm link react-scripts globally
  2. create new create-react-app
  3. npm link react-scripts in new app
  4. modify eslintConfig in package.json as follows:
 "extends": [
"eslint:recommended",
"react-app"
]
  1. exercise the script, e.g.:
    npm run build
  2. verify output
./src/serviceWorker.js
Line 44: Unexpected console statement no-console
Line 72: Unexpected console statement no-console
Line 85: Unexpected console statement no-console
Line 97: Unexpected console statement no-console
Line 123: Unexpected console statement no-console

Allow react app to configure eslint without resorting to eject
@mrmckeb

Copy link
Copy Markdown
Contributor

Hi @chyipin, thanks for your time here, but this is a duplicate of #7036, which will resolve this.

@mrmckebmrmckeb closed this Jul 15, 2019
@chyipin

Copy link
Copy Markdown
ContributorAuthor

Thanks for the heads up. I'll follow the other PR.

@chyipin
chyipin deleted the support-app-eslintrc branch July 15, 2019 16:07
@locklockBot locked and limited conversation to collaborators Jul 20, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@chyipin@mrmckeb@facebook-github-bot